Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 e2e: temporarily schedule all workspaces on the root shard for tmc-related tests #2651

Conversation

p0lyn0mial
Copy link
Contributor

Summary

the issue will be eventually addressed in #2649

Related issue(s)

#2596

@vincepri
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@sttts
Copy link
Member

sttts commented Jan 20, 2023

Am not that happy with this. Compare 228ab97.

@sttts
Copy link
Member

sttts commented Jan 23, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@p0lyn0mial p0lyn0mial changed the title 🐛 e2e/reconciler/scheduling: temporarily schedule all workspaces on the root shard 🐛 e2e: temporarily schedule all workspaces on the root shard for tmc-related tests Jan 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@p0lyn0mial
Copy link
Contributor Author

changed 2 new tests that are very flaky TestDeploymentCoordinator and TestDNSResolution

@sttts
Copy link
Member

sttts commented Jan 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit b0d1d8c into kcp-dev:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants