Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 reconciler/apibinding: filter by cluster through index, not manually #3166

Merged
merged 1 commit into from
Sep 18, 2024
Merged

🐛 reconciler/apibinding: filter by cluster through index, not manually #3166

merged 1 commit into from
Sep 18, 2024

Conversation

sttts
Copy link
Member

@sttts sttts commented Sep 18, 2024 •
edited
Loading

Summary

The apibinding reconciler listed ALL bindings and then filtered by cluster. Obviously, this can be done through the informer indexer.

Related issue(s)

Fixes #

Release Notes

Optimize apibinding reconciler to produce less work for the memory garbage collector.

@sttts
reconciler/apibinding: filter by cluster through index, not manually
6e29dd5 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0659fe6095be2b97192ddc92113c833dd5d437c5

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@kcp-ci-bot kcp-ci-bot merged commit a19096b into kcp-dev:main Sep 18, 2024
16 checks passed
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sttts @mjudeikis @kcp-ci-bot