Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 reconciler/apibinding: filter by cluster through index, not manually #3166

Merged
merged 1 commit into from
Sep 18, 2024
Merged

🐛 reconciler/apibinding: filter by cluster through index, not manually #3166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions pkg/reconciler/apis/apibinding/apibinding_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,22 +82,7 @@ func NewController(
kcpClusterClient: kcpClusterClient,

listAPIBindings: func(clusterName logicalcluster.Name) ([]*apisv1alpha1.APIBinding, error) {
list, err := apiBindingInformer.Lister().List(labels.Everything())
if err != nil {
return nil, err
}

var ret []*apisv1alpha1.APIBinding

for i := range list {
if logicalcluster.From(list[i]) != clusterName {
continue
}

ret = append(ret, list[i])
}

return ret, nil
return apiBindingInformer.Lister().Cluster(clusterName).List(labels.Everything())
},
listAPIBindingsByAPIExport: func(export *apisv1alpha1.APIExport) ([]*apisv1alpha1.APIBinding, error) {
// binding keys by full path
Expand Down
Loading