build: Disable exemplars #2167
Merged
build: Disable exemplars #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jachym-tousek-keboola
requested review from
Matovidlo and
hosekpeter
as code owners
Matovidlo
approved these changes
Dec 3, 2024
hosekpeter
approved these changes
Dec 3, 2024
Apps Proxy Kubernetes Diff [CI]Between Expand--- /tmp/artifacts/test-k8s-state.old.json.processed.kv 2024-12-03 09:02:06.389603185 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv 2024-12-03 09:02:06.509604194 +0000
@@ -56,0 +57,3 @@
+<Deployment/apps-proxy>.spec.template.spec.containers[0].env[10] = {};
+<Deployment/apps-proxy>.spec.template.spec.containers[0].env[10].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Deployment/apps-proxy>.spec.template.spec.containers[0].env[10].value = "always_off";
@@ -111 +114 @@
-<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:ec4ca58-1733216195";
+<Deployment/apps-proxy>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:73de7f7-1733216463";
@@ -322,0 +326,9 @@
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10] = {};
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10] = {};
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10] = {};
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].value = "always_off";
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].value = "always_off";
+<Pod/apps-proxy-<hash>>.spec.containers[0].env[10].value = "always_off";
@@ -485,3 +497,3 @@
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:ec4ca58-1733216195";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:ec4ca58-1733216195";
-<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:ec4ca58-1733216195";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:73de7f7-1733216463";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:73de7f7-1733216463";
+<Pod/apps-proxy-<hash>>.spec.containers[0].image = "docker.io/keboola/apps-proxy:73de7f7-1733216463";
@@ -854,0 +867,3 @@
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].env[10] = {};
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].env[10].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].env[10].value = "always_off";
@@ -909 +924 @@
-<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:ec4ca58-1733216195";
+<ReplicaSet/apps-proxy-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/apps-proxy:73de7f7-1733216463";
(see artifacts in the Github Action for more information) |
Templates API Kubernetes Diff [CI]Between Expand--- /tmp/artifacts/test-k8s-state.old.json.processed.kv 2024-12-03 09:04:02.554038705 +0000
+++ /tmp/artifacts/test-k8s-state.new.json.processed.kv 2024-12-03 09:04:02.762040149 +0000
@@ -148,0 +149,3 @@
+<Deployment/templates-api>.spec.template.spec.containers[0].env[12] = {};
+<Deployment/templates-api>.spec.template.spec.containers[0].env[12].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Deployment/templates-api>.spec.template.spec.containers[0].env[12].value = "always_off";
@@ -194 +197 @@
-<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:ec4ca58-1733216200";
+<Deployment/templates-api>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:73de7f7-1733216519";
@@ -611,0 +615,9 @@
+<Pod/templates-api-<hash>>.spec.containers[0].env[12] = {};
+<Pod/templates-api-<hash>>.spec.containers[0].env[12] = {};
+<Pod/templates-api-<hash>>.spec.containers[0].env[12] = {};
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].value = "always_off";
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].value = "always_off";
+<Pod/templates-api-<hash>>.spec.containers[0].env[12].value = "always_off";
@@ -747,3 +759,3 @@
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:ec4ca58-1733216200";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:ec4ca58-1733216200";
-<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:ec4ca58-1733216200";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:73de7f7-1733216519";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:73de7f7-1733216519";
+<Pod/templates-api-<hash>>.spec.containers[0].image = "docker.io/keboola/templates-api:73de7f7-1733216519";
@@ -1371,0 +1384,3 @@
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].env[12] = {};
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].env[12].name = "OTEL_METRICS_EXEMPLAR_FILTER";
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].env[12].value = "always_off";
@@ -1417 +1432 @@
-<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:ec4ca58-1733216200";
+<ReplicaSet/templates-api-<hash>>.spec.template.spec.containers[0].image = "docker.io/keboola/templates-api:73de7f7-1733216519";
@@ -1488,0 +1504,12 @@
+<Secret/sh.helm.release.v1.templates-api-etcd.v2> = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.apiVersion = "v1";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.data = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.kind = "Secret";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels = {};
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.name = "templates-api-etcd";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.owner = "helm";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.labels.version = "2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.name = "sh.helm.release.v1.templates-api-etcd.v2";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.metadata.namespace = "templates-api";
+<Secret/sh.helm.release.v1.templates-api-etcd.v2>.type = "helm.sh/release.v1";
(see artifacts in the Github Action for more information) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #2138 for templates and apps proxy.
We can try to revert it later. The issue should be fixed by open-telemetry/opentelemetry-go#5995 but it isn't tagged yet.