Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't have separate values like resources, securityContext for keda-operator and keda-operator-metrics-apiserver containers #232

Closed
AshutoshNirkhe opened this issue Jan 24, 2022 · 4 comments · Fixed by #239
Closed

Can't have separate values like resources, securityContext for keda-operator and keda-operator-metrics-apiserver containers #232

AshutoshNirkhe opened this issue Jan 24, 2022 · 4 comments · Fixed by #239
Labels
enhancement New feature or request

Comments

@AshutoshNirkhe
Copy link
Contributor

AshutoshNirkhe commented Jan 24, 2022 •
edited by tomkerkhove
Loading

Expected Behavior

We should be able to define different values for parameters like securityContext, resources etc for keda-operator and keda-operator-metrics-apiserver containers.

Instead define hierarchy like,

.Values.operator.securityContext
.Values.operator-metrics-apiserver.securityContext

Actual Behavior

Parameters like securityContext, resources etc are defined at root level i.e. .values.securityContext , they are applied to both containers keda-operator and keda-operator-metrics-apiserver containers.

Steps to Reproduce the Problem

None

Specifications

  • KEDA Version: v2.5.1
  • Platform & Version: Please elaborate
  • Kubernetes Version: v1.21.7
  • Scaler(s): Please elaborate
@AshutoshNirkhe AshutoshNirkhe added the bug Something isn't working label Jan 24, 2022
@tomkerkhove
Copy link
Member

That's a fair ask, are you willing to contributing this?

@tomkerkhove tomkerkhove added enhancement New feature or request and removed bug Something isn't working labels Jan 26, 2022
@AshutoshNirkhe
Copy link
Contributor Author

That's a fair ask, are you willing to contributing this?

Sure, let me prepare a PR and ping you again @tomkerkhove

@tomkerkhove
Copy link
Member

Awesome, thank you! Please make sure it is backwards compatible.

AshutoshNirkhe added a commit to AshutoshNirkhe/charts-3 that referenced this issue Jan 27, 2022
@AshutoshNirkhe
Separate parameters like resources, securityContext for keda-operator…
0d5f6e7 
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
@AshutoshNirkhe AshutoshNirkhe mentioned this issue Jan 27, 2022
Merged
2 tasks
@AshutoshNirkhe
Copy link
Contributor Author

Awesome, thank you! Please make sure it is backwards compatible.

please have a look at #239

AshutoshNirkhe added a commit to AshutoshNirkhe/charts-3 that referenced this issue Jan 27, 2022
@AshutoshNirkhe
Separate parameters like resources, securityContext for keda-operator…
37783d1 
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
AshutoshNirkhe added a commit to AshutoshNirkhe/charts-3 that referenced this issue Jan 27, 2022
@AshutoshNirkhe
Separate parameters like resources, securityContext for keda-operator…
d93a50f 
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
AshutoshNirkhe added a commit to AshutoshNirkhe/charts-3 that referenced this issue Jan 27, 2022
@AshutoshNirkhe
Separate parameters like resources, securityContext for keda-operator…
46889d5 
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
AshutoshNirkhe added a commit to AshutoshNirkhe/charts-3 that referenced this issue Jan 27, 2022
@AshutoshNirkhe
Separate parameters like resources, securityContext for keda-operator…
d6d50ae 
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Provide parameters per container for resources & security context AshutoshNirkhe/charts-3
2 participants
@tomkerkhove @AshutoshNirkhe