Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide parameters per container for resources & security context #239

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

AshutoshNirkhe
Copy link
Contributor

@AshutoshNirkhe AshutoshNirkhe commented Jan 27, 2022

Separate parameters like resources, securityContext for keda-operator and metrics-apiserver, fixes #232

Signed-off-by: AshutoshNirkhe ashutosh.nirkhe@gmail.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable)

Fixes #232

… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
keda/Chart.yaml Outdated Show resolved Hide resolved
keda/templates/12-keda-deployment.yaml Show resolved Hide resolved
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not make it legacy but a convenience approach for when operator & metric server config is the same

keda/README.md Outdated Show resolved Hide resolved
keda/README.md Outdated Show resolved Hide resolved
… and metrics-apiserver, fixes kedacore#232

Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
@djsly
Copy link

djsly commented Jan 31, 2022

Thanks a lot @AshutoshNirkhe for this work

@tomkerkhove tomkerkhove changed the title Separate parameters like resources, securityContext for keda-operator… feat: Provide parameters per container for resources & security context Feb 1, 2022
@tomkerkhove tomkerkhove merged commit 49ad5e3 into kedacore:main Feb 1, 2022
@tomkerkhove tomkerkhove mentioned this pull request Feb 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants