-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide parameters per container for resources & security context #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and metrics-apiserver, fixes kedacore#232 Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
tomkerkhove
suggested changes
Jan 27, 2022
… and metrics-apiserver, fixes kedacore#232 Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
tomkerkhove
reviewed
Jan 27, 2022
tomkerkhove
reviewed
Jan 27, 2022
… and metrics-apiserver, fixes kedacore#232 Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
… and metrics-apiserver, fixes kedacore#232 Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
tomkerkhove
reviewed
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not make it legacy but a convenience approach for when operator & metric server config is the same
… and metrics-apiserver, fixes kedacore#232 Signed-off-by: AshutoshNirkhe <ashutosh.nirkhe@gmail.com>
Thanks a lot @AshutoshNirkhe for this work |
JorTurFer
approved these changes
Feb 1, 2022
tomkerkhove
approved these changes
Feb 1, 2022
tomkerkhove
changed the title
Separate parameters like resources, securityContext for keda-operator…
feat: Provide parameters per container for resources & security context
Feb 1, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate parameters like resources, securityContext for keda-operator and metrics-apiserver, fixes #232
Signed-off-by: AshutoshNirkhe ashutosh.nirkhe@gmail.com
Provide a description of what has been changed
Checklist
Fixes #232