Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceMonitor instead of PodMonitor in KEDA #339

Closed
JorTurFer opened this issue Nov 29, 2022 · 2 comments · Fixed by #355
Closed

Use ServiceMonitor instead of PodMonitor in KEDA #339

JorTurFer opened this issue Nov 29, 2022 · 2 comments · Fixed by #355
Assignees
@Shaked
Labels
help wanted Extra attention is needed

Comments

@JorTurFer
Copy link
Member

We are using PodMonitor (Prometheus CRD) to define the scrapping rules in KEDA chart, but both deployments have service indeed, so we should use ServiceMonitor manifests. In cases with multiple KEDA instances, ServiceMonitor allows grouping the metrics by service and Podmonitor doesn't
@tomkerkhove tomkerkhove added the help wanted Extra attention is needed label Nov 30, 2022
@Shaked
Copy link
Contributor

Shaked commented Jan 3, 2023

I can help with this issue

@JorTurFer
Copy link
Member Author

Super! Thanks for the help ❤️

Shaked added a commit to Shaked/charts that referenced this issue Jan 4, 2023
@Shaked
feat: add ServiceMonitor support kedacore#339
f1a850a
Shaked added a commit to Shaked/charts that referenced this issue Jan 4, 2023
@Shaked
feat: add ServiceMonitor support kedacore#339
1b94ab9 
Signed-off-by: Shaked Klein Orbach <klein.shaked@gmail.com>
@Shaked Shaked mentioned this issue Jan 4, 2023
Merged
3 tasks
tomkerkhove pushed a commit that referenced this issue Jan 5, 2023
@Shaked
Adds support for Prometheus ServiceMonitor & adds missing Prometheus …
eaf7be2 
…scraping annotations (#355)

Fixes #339
Fixes #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaked Shaked

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@Shaked @tomkerkhove @JorTurFer