Adds support for Prometheus ServiceMonitor & adds missing Prometheus scraping annotations #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Prometheus ServiceMonitor as part of #339 and fixes the missing Prometheus scraping annotations of #354 .
While the
metricServer
configuration is deprecated, I assume that it might be in use in some places and easier to set before migrating for some folks, so I have added the same support to it until it will be completely removed.Checklist
Fixes #339
Fixes #354