Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Prometheus ServiceMonitor & adds missing Prometheus scraping annotations #355

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

Shaked
Copy link
Contributor

@Shaked Shaked commented Jan 4, 2023

This PR adds support for Prometheus ServiceMonitor as part of #339 and fixes the missing Prometheus scraping annotations of #354 .

While the metricServer configuration is deprecated, I assume that it might be in use in some places and easier to set before migrating for some folks, so I have added the same support to it until it will be completely removed.

Checklist

Fixes #339
Fixes #354

Shaked added 3 commits January 5, 2023 01:46
Signed-off-by: Shaked Klein Orbach <klein.shaked@gmail.com>
Signed-off-by: Shaked Klein Orbach <klein.shaked@gmail.com>
Signed-off-by: Shaked Klein Orbach <klein.shaked@gmail.com>
@Shaked Shaked requested a review from a team as a code owner January 4, 2023 23:55
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tomkerkhove tomkerkhove merged commit eaf7be2 into kedacore:main Jan 5, 2023
@nguyenhoaibao
Copy link

@tomkerkhove when will this fix be released? I see the current latest version (v2.9.3) doesn't contain this fix.

@tomkerkhove
Copy link
Member

This should be be shipped with KEDA v2.10 if I'm not mistaken as this is not impacting end-users; unless I'm mistaken ?

@fdebuire
Copy link

fdebuire commented Feb 2, 2023

@tomkerkhove I am also waiting for the fix, according to #386 it has been released but the release seems not available:

helm search repo kedacore
NAME                                          	CHART VERSION	APP VERSION	DESCRIPTION
kedacore/keda                                 	2.9.3        	2.9.2      	Event-based autoscaler for workloads on Kubernetes

@JorTurFer
Copy link
Member

JorTurFer commented Feb 2, 2023

You can see what is released on each version in the specific release branch, in this case for v2.9 https://github.com/kedacore/charts/tree/release/v2.9
As you can see, this PR isn't in the release branch, you can't trust in GH here because the commit "is released" as part of other chart

@fdebuire
Copy link

fdebuire commented Feb 3, 2023

Sorry it's my bad, after doing a helm repo update I can see the 2.9.4version of the Helm chart

@JorTurFer
Copy link
Member

Sorry it's my bad, after doing a helm repo update I can see the 2.9.4version of the Helm chart

no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrape Operator metrics via Prometheus Use ServiceMonitor instead of PodMonitor in KEDA
5 participants