Add keda http add-on operator charts #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
khaosdoctor
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
2 tasks
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
tomkerkhove
suggested changes
Apr 7, 2021
|
@khaosdoctor Please move the CRDs as per #140 as well, Helm doesn't handle them well :/ |
|
Let's use |
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
@tomkerkhove applied the changes from your review, could you please review again? |
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
Added change from kedacore/http-add-on#115 to setup the chart |
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
arschles
requested changes
Apr 27, 2021
There was a problem hiding this comment.
I have a single nitpick change, but +1 to @tomkerkhove's requested changes too
2 tasks
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
@tomkerkhove @arschles can you PTAL? |
arschles
approved these changes
May 6, 2021
tomkerkhove
suggested changes
May 7, 2021
There was a problem hiding this comment.
LGTM, we only need two last changes:
- Fix the app version references below
- Provide a new CI workflow for this chart, similar to KEDA Core CI
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
Suggestions done, let me create the CI |
tomkerkhove
reviewed
May 11, 2021
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
|
@tomkerkhove I added the CI pipeline based on the one that's already here, can you PTAL to check if that's useful? |
tomkerkhove
approved these changes
May 12, 2021
|
THank you @khaosdoctor! I'll clean it up in a separate PR! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving HTTP add-on charts here
Checklist
Fixes kedacore/http-add-on#104