Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing MS-apiserver MS path #494

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

emctl
Copy link
Contributor

@emctl emctl commented Jul 4, 2023

#488 investigation, looks like this may have been missed as part of this - this I think its safe to remove that extra field.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #
#488

Signed-off-by: emctl <8000237+emctl@users.noreply.github.com>
@JorTurFer
Copy link
Member

Yeah, the path isn't settable. Thanks for the fix ❤️

Is the field used at any other point? can se remove it from helm values?

@emctl
Copy link
Contributor Author

emctl commented Jul 8, 2023

@JorTurFer - I believe it was already removed here

@JorTurFer JorTurFer enabled auto-merge (squash) July 8, 2023 12:14
@JorTurFer JorTurFer merged commit 8b956d0 into kedacore:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants