Remove deprecated prometheus metrics from MS

[JorTurFer]

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• README is updated with new configuration values (if applicable)
• A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Related to kedacore/keda#3930

[EppO]

keda-operator is also exposing metrics on default port 8080 like keda_scaler_, keda_scaled_objects_, keda_resource_* or keda_trigger_*. There are no annotations for that currently, we would need to add:

    prometheus.io/scrape: "true"
    prometheus.io/port: {{ .Values.prometheus.operator.port | quote }}
    prometheus.io/path: "/metrics"

in https://github.com/kedacore/charts/tree/main/keda/templates/manager/deployment.yaml
I also noticed that https://github.com/kedacore/charts/blob/main/keda/templates/manager/deployment.yaml#LL101C32-L101C32 is static, so if you change the value of prometheus.operator.port in the values.yaml, it may not work

[JorTurFer]

nice catches!
Thanks for the feedback ❤️
I have to redo this PR soon, so I'll address them 😄

[zroubalik]

@JorTurFer could you please rebase this PR?

[JorTurFer]

@JorTurFer could you please rebase this PR?

Yes, I'll do it during this week

[JorTurFer]

I still got this pending but I'm out of the office :(

[JorTurFer]

@JorTurFer could you please rebase this PR?

done!

[JorTurFer]

PTAL @zroubalik , we need to merge this because the chart is "broken" until it due to the parameters change in MS

[outime]

@JorTurFer @zroubalik @tomkerkhove my apologies for the multi-mention but I've just hit this and I was wondering if you're willing to push up a revision of the current KEDA chart to contain this and few other commits?

[JorTurFer]

@JorTurFer @zroubalik @tomkerkhove my apologies for the multi-mention but I've just hit this and I was wondering if you're willing to push up a revision of the current KEDA chart to contain this and few other commits?

No worries for the mention 😄
We plan to cut a release next week: kedacore/keda#4795