Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Remove deprecated prometheus metrics from Metric Server #4471

Closed
wants to merge 5 commits into from
Closed

Breaking change: Remove deprecated prometheus metrics from Metric Server #4471

wants to merge 5 commits into from

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Apr 24, 2023 •
edited
Loading

Provide a description of what has been changed

Checklist

Fixes #3930

@JorTurFer
Breaking change: Remove deprecated prometheus metrics from MS
e5155f5 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner April 24, 2023 20:56
@JorTurFer
Breaking change: Remove deprecated prometheus metrics from MS
5dcbaf7 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update changelog
b30335c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix typo
fa8a1d2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 24, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Apr 24, 2023
Closed
@tomkerkhove tomkerkhove changed the title Breaking change: Remove deprecated prometheus metrics from MS Breaking change: Remove deprecated prometheus metrics from Metric Server Apr 25, 2023
tomkerkhove
tomkerkhove reviewed Apr 25, 2023
View reviewed changes
@JorTurFer JorTurFer mentioned this pull request Apr 25, 2023
Closed
@JorTurFer @tomkerkhove
apply feedback
b21160f 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 25, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer closed this Apr 25, 2023
@JorTurFer
Copy link
Member Author

@zroubalik will tackle this PR and the removal of the querying feature in the metrics server

@JorTurFer JorTurFer deleted the remove-deprecated-ms branch July 27, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated code for exposing Prometheus Metrics from Metrics Server
2 participants
@JorTurFer @tomkerkhove