Release 2.13.0 #593

wozniakjan · 2024-01-19T09:17:27Z

Preparation for the KEDA release 2.13.0

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Commits are signed with Developer Certificate of Origin (DCO - learn more)
README is updated with new configuration values (if applicable) learn more

1) CRD update - resolved in #593 (comment), `949b54f`

old question

1) CRD update - `2d22f00`

I did following procedure

# template CRDs for the latest release
kustomize build https://github.com/kedacore/keda/config/crd?ref=v2.13.0 > all.yaml

# split the templated file
yq -s '"crd-" + .spec.names.plural + ".yaml"' all.yaml

# move the split files to the correct location
mv crd-*.yaml ./keda/templates/crds/

and then copied back the helm templating manually to those CRDs but there seems to be a good amount of drift so I am sceptical of my process ...

2) removing deprecated webhook enable flag - `8e863fa`

the notes mentioned to remove it, just wanted to confirm this is the right time and place :)

tomkerkhove · 2024-01-19T10:02:25Z

I am not entirely sure about these two commits, ptal @kedacore/keda-core-contributors

1) CRD update - 2d22f00

I did following procedure
# template CRDs for the latest release
kustomize build https://github.com/kedacore/keda/config/crd?ref=v2.13.0 > all.yaml

# split the templated file
yq -s '"crd-" + .spec.names.plural + ".yaml"' all.yaml

# move the split files to the correct location
mv crd-*.yaml ./keda/templates/crds/
and then copied back the helm templating manually to those CRDs but there seems to be a good amount of drift so I am sceptical of my process ...

I honestly just copy the artifacts from KEDA's release and past them in the files, I do not use Kustomize for it

tomkerkhove · 2024-01-19T10:02:37Z

Mind adding the change from #558 in this PR please?

tomkerkhove · 2024-01-19T10:04:42Z

2) removing deprecated webhook enable flag - 8e863fa

the notes mentioned to remove it, just wanted to confirm this is the right time and place :)

@kedacore/keda-maintainers I'm not sure if we should do hard delete, or if we should change the default to true? I personally prefer the latter as people can still turn it off if they want, but recall we may have taken a dependency on it in 2.13

wozniakjan · 2024-01-19T10:08:22Z

Mind adding the change from #558 in this PR please?

I'm on it, thanks for reminding :)

@kedacore/keda-maintainers I'm not sure if we should do hard delete, or if we should change the default to true? I personally prefer the latter as people can still turn it off if they want, but recall we may have taken a dependency on it in 2.13

I would be in favour of keeping it and given the default is already true, I can just easily change the deprecation/removal note to mention 2.13 instead?

maybe @zroubalik or @JorTurFer have an opinion?

wozniakjan · 2024-01-19T10:32:35Z

I honestly just copy the artifacts from KEDA's release and past them in the files, I do not use Kustomize for it

@tomkerkhove, I investigated the diff a bit closer and the culprit is the yq I used to auto-split the crds yaml, lot a whitespace changes and line breaks in a different location, I will replace my attempt for automation with manual labour to reduce the diff :)

keda/values.yaml

tomkerkhove · 2024-01-19T11:13:28Z

I only see changes for trigger authentication, just to verify - The other CRDs did not change?

JorTurFer · 2024-01-19T11:19:45Z

I only see changes for trigger authentication, just to verify - The other CRDs did not change?

I don't think so, but let me double-check

JorTurFer · 2024-01-19T11:28:23Z

Sorry for the noise, could we include this PR as part of the release? #591

tomkerkhove · 2024-01-19T11:30:05Z

Merged, all we need to do is sync and re-package

wozniakjan · 2024-01-19T11:30:46Z

Merged, all we need to do is sync and re-package

I'm on it :)

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

$ helm package keda --destination docs Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

$ helm repo index docs --url https://kedacore.github.io/charts Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan · 2024-01-19T11:34:17Z

I don't think so, but let me double-check

I double checked, looks like only TA and CTA changed + CloudEvent CRDs got added as a new one in #572. These are the only diffs regarding CRDs I observed.

Also sync and re-package is now pushed.

tomkerkhove · 2024-01-19T11:42:50Z

@wozniakjan Did you verify that https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-cloudeventsources.yaml does not need any changes?

JorTurFer · 2024-01-19T11:44:03Z

@wozniakjan Did you verify that main/keda/templates/crds/crd-cloudeventsources.yaml does not need any changes?

I did it

…uing KEDA TLS certificates (#530) * feat(keda): ✨ Allow providing own cert-manager issuer in TLS certificate Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * docs(keda): 📝 Generate Helm docs Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix(keda): 🐛 Inject CA from cert-manager Certificate when providing own Issuer Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * refactor(keda): ♻️ Refactor values format Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * revert(keda): ⏪ Revert unnecessary auto-formatting Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore: Improve the CI on PRs to be more efficient (#540) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix(http-add-on): Refactor the chart for next version (#523) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * feat(add-on): Supporting streamInterval configuration (#541) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore(add-on): Ship Release 0.6.0 (#543) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore: update versions in README.md (#546) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * feat: update crd to allow vault secret to handle write operation (#548) Signed-off-by: Loïs Postula <lois@postu.la> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix the svc name of webhook to avoid breaking istio (#551) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Show only logs with a severity level of ERROR or higher in the stderr (#506) Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Support profiling for keda components (#549) Signed-off-by: yuval weber <yuval199985@gmail.com> Signed-off-by: unknown <yuval199985@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix TriggerAuthentication - added configuration for validation webhook (#553) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix: Declare missing port in KEDA operator (#552) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Allow image registry override for all keda components (#557) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * docs: Clarify that contributors do not have to ship Helm chart (#573) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * add disable-compression arg for both operator and metrics-server (#554) Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * feat: Introduce CloudEventSources CRD and adding ClusterName parameter (#572) * Add CloudEventSources Crd and ClustetName Parameter Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update keda/values.yaml Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Fix Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Revert unnecessary update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * store 2.12.1 package at `main` (#577) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix: restore http-add-on chart 0.6.0 indexing (#579) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix(add-on): Use 'main' tag for KEDA installation during CI (#582) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * set securityContext for http-add-on chart (#561) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix http-add-on operator resources (#567) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix http-add-on verbosity configuration (#568) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore: Adjust RBAC with code (#585) * chore: Adjust RBAC with code Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix typo Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix: Don't recreate CA with 8 months until it expires (#586) Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * feat(ClusterRole): Add RBAC rule to allow access to `LimitRange` (#588) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * remove not required insecureSkipTLSVerify (#564) Signed-off-by: Frank Kloeker <f.kloeker@telekom.de> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Update templates/webhooks deployment (#590) Align deployment for extraVolumes and extraVolumesMount for fix problem Error: YAML parse error on keda/templates/webhooks/deployment.yaml: error converting YAML to JSON: yaml: line 96: did not find expected key Signed-off-by: ferndem <39851927+ferndem@users.noreply.github.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix Prometheus metrics handling for the operator. (#555) The current state of the Helm chart is slightly confusing, because: - There's no easy way to really disable prometheus metrics -- `--enable-prometheus-metrics` defaults to true anthe current code either emits `--enable-prometheus-metrics=true` or nothing at all (making it `true` once again). - The `http` container port is actually a `metrics` port (by convention from .e.g. webhook), but is present regardless of whether Prometheus metrics are enabled or not. To make it less confusing, this PR proposes renaming it. Signed-off-by: Milan Plzik <milan.plzik@grafana.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Fix Remove app.kubernetes.io/instance label in crd (#556) Signed-off-by: choisungwook <kgg1959@naver.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Support crd-specific annotations (#584) * support crd-specific annotations Signed-off-by: Adam Walford <adamw@speechmatics.com> * update readme Signed-off-by: Adam Walford <adamw@speechmatics.com> * update docs using helm-docs Signed-off-by: Adam Walford <adamw@speechmatics.com> --------- Signed-off-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Add ciliumnetworkpolicies (#558) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Add tlsConfig for ServiceMonitor (#591) Co-authored-by: guicholeo <leo.sanchez@resideo.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * Release 2.13.0 (#593) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * fix: Ship v2.13.1 with missing RoleBinding (#595) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore(add-on): Apply HTTP Add-on changes on Helm chart (#598) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * chore(add-on): Release v0.7.0 (#599) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> * refactor: Unify cert-manager annotations Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> --------- Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Loïs Postula <lois@postu.la> Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: yuval weber <yuval199985@gmail.com> Signed-off-by: unknown <yuval199985@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Frank Kloeker <f.kloeker@telekom.de> Signed-off-by: ferndem <39851927+ferndem@users.noreply.github.com> Signed-off-by: Milan Plzik <milan.plzik@grafana.com> Signed-off-by: choisungwook <kgg1959@naver.com> Signed-off-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Loïs Postula <lois@postu.la> Co-authored-by: Roy Gao <137811914+congzhegao@users.noreply.github.com> Co-authored-by: Adarsh Verma <113962919+Adarsh-verma-14@users.noreply.github.com> Co-authored-by: yuval weber <yuval199985@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Radek Fojtik <68660951+radekfojtik@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Frank Kloeker <eumel@arcor.de> Co-authored-by: Andrew <35912177+aballman@users.noreply.github.com> Co-authored-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io> Co-authored-by: ferndem <39851927+ferndem@users.noreply.github.com> Co-authored-by: Milan Plžík <4592597+mplzik@users.noreply.github.com> Co-authored-by: choisungwook <sungwook0724@lguplus.co.kr> Co-authored-by: Adam Walford <34867732+awalford16@users.noreply.github.com> Co-authored-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: guicholeo <leo.sanchez@resideo.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan force-pushed the release_2.13.0 branch from 3208066 to e06d213 Compare January 19, 2024 09:43

wozniakjan mentioned this pull request Jan 19, 2024

Release: 2.13.0 kedacore/keda#5275

Closed

25 tasks

wozniakjan marked this pull request as ready for review January 19, 2024 09:55

wozniakjan requested a review from a team as a code owner January 19, 2024 09:56

wozniakjan force-pushed the release_2.13.0 branch from e06d213 to 972c0ca Compare January 19, 2024 10:17

wozniakjan force-pushed the release_2.13.0 branch from 972c0ca to 7112110 Compare January 19, 2024 10:42

JorTurFer reviewed Jan 19, 2024

View reviewed changes

keda/values.yaml Outdated Show resolved Hide resolved

wozniakjan force-pushed the release_2.13.0 branch from 7112110 to c4e20df Compare January 19, 2024 11:03

JorTurFer approved these changes Jan 19, 2024

View reviewed changes

tomkerkhove approved these changes Jan 19, 2024

View reviewed changes

wozniakjan added 6 commits January 19, 2024 12:31

bump chart version to v 2.13.0

161b553

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

update chart notes with k8s 1.27 support

6b53a73

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

bump keda to 2.13.0 in README

92db184

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

update CRDs to v2.13.0

336c7ea

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

create new package

e69635f

$ helm package keda --destination docs Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

update helm index

74acc50

$ helm repo index docs --url https://kedacore.github.io/charts Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

wozniakjan force-pushed the release_2.13.0 branch from c4e20df to 74acc50 Compare January 19, 2024 11:32

tomkerkhove merged commit 0520e8f into kedacore:main Jan 19, 2024
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.13.0 #593

Release 2.13.0 #593

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

1) CRD update - `2d22f00`

tomkerkhove commented Jan 19, 2024

1) CRD update - 2d22f00

tomkerkhove commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

2) removing deprecated webhook enable flag - 8e863fa

wozniakjan commented Jan 19, 2024 •

edited

Loading

wozniakjan commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

Release 2.13.0 #593

Release 2.13.0 #593

Conversation

wozniakjan commented Jan 19, 2024

Checklist

wozniakjan commented Jan 19, 2024 • edited Loading

1) CRD update - resolved in #593 (comment), 949b54f

1) CRD update - 2d22f00

2) removing deprecated webhook enable flag - 8e863fa

tomkerkhove commented Jan 19, 2024

1) CRD update - 2d22f00

tomkerkhove commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

2) removing deprecated webhook enable flag - 8e863fa

wozniakjan commented Jan 19, 2024 • edited Loading

wozniakjan commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

tomkerkhove commented Jan 19, 2024

wozniakjan commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 • edited Loading

tomkerkhove commented Jan 19, 2024

JorTurFer commented Jan 19, 2024

wozniakjan commented Jan 19, 2024 •

edited

Loading

1) CRD update - resolved in #593 (comment), `949b54f`

1) CRD update - `2d22f00`

2) removing deprecated webhook enable flag - `8e863fa`

wozniakjan commented Jan 19, 2024 •

edited

Loading

wozniakjan commented Jan 19, 2024 •

edited

Loading