Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: 2.13.0 #5275

Closed
24 of 25 tasks
JorTurFer opened this issue Dec 11, 2023 · 25 comments
Closed
24 of 25 tasks

Release: 2.13.0 #5275

JorTurFer opened this issue Dec 11, 2023 · 25 comments
Assignees
@wozniakjan @tomkerkhove
Labels
governance release-management All issues related to how we release

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Dec 11, 2023 •
edited by tomkerkhove
Loading

This issue template is used to track the rollout of a new KEDA version.

For the full release process, we recommend reading this document.

Required items

Nice to have

Not needed

Timeline

We aim to release this release in the week of January 11.

Progress
@JorTurFer JorTurFer added release-management All issues related to how we release governance labels Dec 11, 2023
@tomkerkhove
Copy link
Member

Added the blocker ones to the 2.13 milestone of our roadmap with high prio

@wozniakjan wozniakjan mentioned this issue Jan 4, 2024
Closed
@tomkerkhove tomkerkhove assigned wozniakjan and unassigned zroubalik and JorTurFer Jan 9, 2024
@wozniakjan wozniakjan mentioned this issue Jan 10, 2024
Merged
1 task
@wozniakjan
Copy link
Member

wozniakjan commented Jan 11, 2024 •
edited
Loading

quick update regarding some of the items

intending to tackle in #5360

  • Welcome message supported versions are up-to-date (@wozniakjan)

handled by @tomkerkhove already in #5018

@wozniakjan wozniakjan mentioned this issue Jan 15, 2024
Merged
1 task
@zroubalik zroubalik pinned this issue Jan 15, 2024
@tomkerkhove
Copy link
Member

Holding off creating a release until these are merged:

@zroubalik zroubalik mentioned this issue Jan 18, 2024
Merged
1 task
@tomkerkhove
Copy link
Member

#5377 is still open so will start release early tomorrow morning CEST

@zroubalik
Copy link
Member

There are open Helm chart PRs that we should consider for the release:

@JorTurFer @tomkerkhove @wozniakjan FYI ^

@JorTurFer
Copy link
Member Author

I've just reviewed them (because sadly I was the blocker on almost all of them).
Only the cilium one is left

@tomkerkhove
Copy link
Member

Tag created, build ongoing: https://github.com/kedacore/keda/actions/runs/7580118918

@JorTurFer
Copy link
Member Author

Should we include this PR #5407?
a user requested it by slack: https://kubernetes.slack.com/archives/CKZJ36A5D/p1705601623453299
WDYT @tomkerkhove ? @zroubalik ?

@wozniakjan
Copy link
Member

docs PR freshly rebased to include latest merged commits, ptal

@wozniakjan
Copy link
Member

Should we include this PR #5407?

given the tag has been created and build is ongoing, my gut feeling is #5407 will have to wait for next release...

@wozniakjan wozniakjan mentioned this issue Jan 19, 2024
Merged
3 tasks
@wozniakjan
Copy link
Member

I tried to prepare the helm release as well, ptal

@tomkerkhove
Copy link
Member

Should we include this PR #5407? a user requested it by slack: kubernetes.slack.com/archives/CKZJ36A5D/p1705601623453299 WDYT @tomkerkhove ? @zroubalik ?

I did not wait for it since we did not identify as a blocking feature, sorry =)

@tomkerkhove
Copy link
Member

Release notes and discussion updated with changelog: https://github.com/kedacore/keda/releases/tag/v2.13.0

@tomkerkhove tomkerkhove mentioned this issue Jan 19, 2024
Merged
1 task
@tomkerkhove
Copy link
Member

Images imported in Snyk

@tomkerkhove
Copy link
Member

Hotfix branch: https://github.com/kedacore/keda/tree/release/v2.13

@tomkerkhove tomkerkhove mentioned this issue Jan 19, 2024
Merged
1 task
@tomkerkhove
Copy link
Member

We should be good to go, he only remaining aspect is Helm chart + announcement which I will do once chart is ready.

@wozniakjan feel free to take your time, I'm on CNCF slack if you need me.

@wozniakjan
Copy link
Member

thanks @tomkerkhove, I believe I have clarity regarding both CRD diff as well as webhook disablement option. Ptal if kedacore/charts#593 is ready to merge.

@tomkerkhove
Copy link
Member

Helm is merged and published release notes

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 19, 2024 •
edited
Loading

And I think that it's time for the 1st hotfix:

2024/01/19 11:51:06 maxprocs: Updating GOMAXPROCS=1: using minimum allowed GOMAXPROCS
2024-01-19T11:51:06Z	INFO	setup	Starting manager
2024-01-19T11:51:06Z	INFO	setup	KEDA Version: 2.13.0
2024-01-19T11:51:06Z	INFO	setup	Git Commit: 367fcd32f1e72be504ada53165d07c33d75fc0f7
2024-01-19T11:51:06Z	INFO	setup	Go Version: go1.21.6
2024-01-19T11:51:06Z	INFO	setup	Go OS/Arch: linux/amd64
2024-01-19T11:51:06Z	INFO	setup	Running on Kubernetes 1.27	{"version": "v1.27.7"}
2024-01-19T11:51:07Z	INFO	starting server	{"kind": "health probe", "addr": "[::]:8081"}
I0119 11:51:07.055862       1 leaderelection.go:250] attempting to acquire leader lease keda/operator.keda.sh...
2024-01-19T11:51:07Z	INFO	controller-runtime.metrics	Starting metrics server
2024-01-19T11:51:07Z	INFO	controller-runtime.metrics	Serving metrics server	{"bindAddress": ":8080", "secure": false}
E0119 11:51:24.388650       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:27.052988       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:30.112698       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:34.269628       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:38.482921       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:41.628618       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:45.826308       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:49.208734       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"
E0119 11:51:52.240208       1 leaderelection.go:369] Failed to update lock: leases.coordination.k8s.io "operator.keda.sh" is forbidden: User "system:serviceaccount:keda:keda-operator" cannot update resource "leases" in API group "coordination.k8s.io" in the namespace "keda"

I guess that it's related with : 367fcd3

@tomkerkhove
Copy link
Member

Please open an issue on the Helm repo for this

@JorTurFer
Copy link
Member Author

Yeah, I'm trying to figure out why this passed e2e test on KEDA side but it's failing using helm

@tomkerkhove
Copy link
Member

Looks like an RBAC issue in the Helm chart

@tomkerkhove
Copy link
Member

@tomkerkhove
Copy link
Member

The release is done 🎉 Thanks for the valuable help, @wozniakjan!

@tomkerkhove
Copy link
Member

Please open an issue on the Helm repo for this

Let's follow-up there, likely this requires Helm hotfix only

@JorTurFer JorTurFer mentioned this issue Jan 19, 2024
Merged
2 tasks
@JorTurFer JorTurFer unpinned this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wozniakjan wozniakjan

@tomkerkhove tomkerkhove

Labels
governance release-management All issues related to how we release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zroubalik @wozniakjan @tomkerkhove @JorTurFer