Add insecureSkipTLS flag for grpc client/server connection #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliaqel-stripe
force-pushed
the
aliaqel/add-insecure-TLS-flag-for-grpc
branch
from
eab382e to
bd9e7a6
Compare
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
3 tasks
zroubalik
reviewed
Jan 18, 2024
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
|
Found a way to do this without needing to disable TLS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag called
insecure-metrics-service-skip-tls-verifyto both the adapter and operator to disable TLS on the GRPC connection between the two services. This flag is defaulted tofalse, i.e the existing behavior.I am adding this change because we use the Envoy service mesh for TLS so we need to disable TLS in our service code in order for our proxy to handle the rest.
I could not find a specific config flag test but since I wrote this in a way that if left unset, you get existing behavior, I expect any issues to show up on the e2e tests.
I did validate in our cluster and I have the expected behavior of being able to disable TLS on both client and server and having the two connect over envoy.
Checklist
Fixes #5408