Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Solr Scaler docs #1093

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Adds Solr Scaler docs #1093

merged 6 commits into from
Mar 23, 2023

Conversation

ithesadson
Copy link
Contributor

@ithesadson ithesadson commented Mar 18, 2023 •
edited
Loading

Provide a description of what has been changed

  • Adds Solr scaler docs to v2.10

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Releates to:
kedacore/keda#4234
kedacore/keda#4355

@ithesadson
add docs for solr
e1348d1 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson ithesadson requested a review from a team as a code owner March 18, 2023 21:24
@netlify
Copy link

netlify bot commented Mar 18, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8376257
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64199a24f2ff270008901e43
😎 Deploy Preview https://deploy-preview-1093--keda.netlify.app/docs/2.11/scalers/solr
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ithesadson
change version
00eb6a0 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
change version
f8df357 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson ithesadson mentioned this pull request Mar 18, 2023
Merged
6 tasks
@ithesadson
rename core to collection
a5a9318 
Signed-off-by: ithesadson <thesadson@gmail.com>
tomkerkhove
tomkerkhove reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting for feature to be merged. However, can you move this file to 2.11 please? 2.10 was already shipped

@ithesadson
change version
9d73a84 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
Copy link
Contributor Author

LGTM, but waiting for feature to be merged. However, can you move this file to 2.11 please? 2.10 was already shipped

@ithesadson ithesadson closed this Mar 20, 2023
@ithesadson ithesadson reopened this Mar 20, 2023
@ithesadson
Copy link
Contributor Author

I accidentally closed the pull request and then reopened it, sorry about that.

@ithesadson
define username under TriggerAuthentication
8376257 
Signed-off-by: ithesadson <thesadson@gmail.com>
@zroubalik zroubalik merged commit bc635d4 into kedacore:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ithesadson @zroubalik @tomkerkhove