Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Scaler): Adds Solr Scaler #4355

Merged
merged 11 commits into from
Mar 23, 2023
Merged

feat(Scaler): Adds Solr Scaler #4355

merged 11 commits into from
Mar 23, 2023

Conversation

ithesadson
Copy link
Contributor

@ithesadson ithesadson commented Mar 12, 2023 •
edited by tomkerkhove
Loading

Provide a description of what has been changed
+Adds Solr Scaler for autoscaling based on solr queries

Checklist

Relates to #4234
Relates to kedacore/keda-docs#1093

@ithesadson
feat(Scaler): Adds Solr Scaler
4521a26 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
feat(Scaler): Adds Solr Scaler
5d3c65f 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
feat(Scaler): Adds Solr Scaler
ff7f9e5 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson ithesadson requested a review from a team as a code owner March 12, 2023 19:22
@ithesadson
feat(Scaler): Adds Solr Scaler
34732cd 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
fix pre-commit errors
432548b 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
edit changelog.md
d7b2297 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
Copy link
Contributor Author

Hi @tomkerkhove , I wrote the scaler and it seems to be working.
If everything is ok and you approve, I can start writing the document.

@zroubalik
Copy link
Member

zroubalik commented Mar 14, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@ithesadson
increase scale out time
0148edf 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
Copy link
Contributor Author

@zroubalik Can you trigger the e2e test again, I increased the time given for scale up

@zroubalik
Copy link
Member

zroubalik commented Mar 17, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@ithesadson
fix e2e test error: remove nodeport, provide access inside the cluster
d7df1f9 
Signed-off-by: ithesadson <thesadson@gmail.com>
@ithesadson
decrease scale out time
9b6d4bd 
Signed-off-by: ithesadson <thesadson@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 17, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Mar 18, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@ithesadson ithesadson mentioned this pull request Mar 18, 2023
Merged
1 task
@ithesadson
Copy link
Contributor Author

I added the document for solr scaler. kedacore/keda-docs#1093

tomkerkhove
tomkerkhove reviewed Mar 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/solr_scaler.go Outdated Show resolved Hide resolved
@ithesadson
edit changelog, rename core to collection
d682f36 
Signed-off-by: ithesadson <thesadson@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 20, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@ithesadson
Copy link
Contributor Author

@zroubalik Can you please trigger to run the CI/validate - amd64 (pull_request) test again?

@tomkerkhove
Copy link
Member

tomkerkhove commented Mar 21, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

@ithesadson
define username under TriggerAuthentication
02c38c8 
Signed-off-by: ithesadson <thesadson@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 21, 2023 •
edited by github-actions bot
Loading

/run-e2e solr*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@zroubalik zroubalik merged commit 078c51b into kedacore:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ithesadson @zroubalik @tomkerkhove