Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paused Annotation Doc #1190

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Jul 18, 2023

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4809
Relates to kedacore/keda#3304

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner July 18, 2023 08:13
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9f2bbfd
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6503b7f62ff91b0008170547
😎 Deploy Preview https://deploy-preview-1190--keda.netlify.app/docs/2.12/concepts/scaling-deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove
Copy link
Member

Would you mind updating the pausing section and cover both annotations and explain which one takes priority over the other please?

https://deploy-preview-1190--keda.netlify.app/docs/2.11/concepts/scaling-deployments/#pause-autoscaling

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide furter explanation of the behaviour when one of pausing or both of them are specified. Thanks!

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@zroubalik zroubalik merged commit f3311d3 into kedacore:main Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants