Provide explicitly pausing annotations of ScaledObjects at the current replica count #4809

SpiritZhou · 2023-07-18T02:21:59Z

Add pausing annotations of ScaledObjects at the current replica count

Refactor current paused checking method of ScaledObjects
Add autoscaling.keda.sh/paused:true in ScaledObjects

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #3304
Relates to kedacore/keda-docs#1190

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

github-actions · 2023-07-18T02:22:10Z

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

tomkerkhove

LGTM

tests/internals/pause_scaledobject_explicitly/pause_scaledobject_explicitly_test.go

tomkerkhove · 2023-07-18T08:59:40Z

/run-e2e internal*
Update: You can check the progress here

tomkerkhove

Can you add an e2e test that applies both paused + paused with specific replica count and make sure that the explicit count wins please?

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

…tZhou/keda into spiritzhou/pauseexplicitly

SpiritZhou · 2023-07-20T06:07:51Z

Add e2e test that applies both paused + paused.

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer · 2023-07-26T21:55:15Z

/run-e2e
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou · 2023-07-27T05:53:28Z

There is a Solr e2e test failed. It seems like that there is a problem when setting up Solr. Do you have any idea to fix it? @JorTurFer

JorTurFer · 2023-07-27T06:43:09Z

There is a Solr e2e test failed. It seems like that there is a problem when setting up Solr. Do you have any idea to fix it? @JorTurFer

Let me check. In any case, you can ignore it as it's not related with this PR

zroubalik · 2023-09-05T13:34:09Z

/run-e2e
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

tomkerkhove · 2023-09-06T06:05:45Z

/run-e2e internal*
Update: You can check the progress here

apis/keda/v1alpha1/scaledobject_types.go

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

tomkerkhove · 2023-09-08T06:18:44Z

/run-e2e
Update: You can check the progress here

tomkerkhove · 2023-09-08T06:19:33Z

@SpiritZhou while waiting for a review; would you mind updating our docs in a separate PR please?

SpiritZhou · 2023-09-11T02:30:03Z

@SpiritZhou while waiting for a review; would you mind updating our docs in a separate PR please?

I have updated our docs (kedacore/keda-docs#1190). Do you mean we need to add more detail info in the doc?

tomkerkhove

LGTM

tomkerkhove · 2023-09-11T07:03:05Z

Any concerns for you @zroubalik / @JorTurFer ?

zroubalik

LGTM, great job!

JorTurFer

Looking good, just an small nit

CHANGELOG.md

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

zroubalik

LGTM, let's merge this once docs PR is finished.

Thanks for the contribution!

SpiritZhou · 2023-09-25T02:04:41Z

LGTM, let's merge this once docs PR is finished.

Thanks for the contribution!

Hi @zroubalik do you mind to review the docs PR again?

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

zroubalik · 2023-09-25T07:58:23Z

/run-e2e pause
Update: You can check the progress here

…t replica count (kedacore#4809) Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: root <root@zhou> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

…t replica count (kedacore#4809) Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: root <root@zhou> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>

SpiritZhou added 3 commits July 17, 2023 13:58

Refactor

22f6388

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

d86b9e7

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

0027735

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested a review from a team as a code owner July 18, 2023 02:21

SpiritZhou added 2 commits July 18, 2023 15:13

Update

25890cc

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Merge branch 'main' into spiritzhou/pauseexplicitly

b5f7f5e

SpiritZhou mentioned this pull request Jul 18, 2023

Add Paused Annotation Doc kedacore/keda-docs#1190

Merged

1 task

tomkerkhove approved these changes Jul 18, 2023

View reviewed changes

tests/internals/pause_scaledobject_explicitly/pause_scaledobject_explicitly_test.go Show resolved Hide resolved

tomkerkhove suggested changes Jul 18, 2023

View reviewed changes

SpiritZhou and others added 2 commits July 20, 2023 14:04

Update

9c26b59

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Merge branch 'spiritzhou/pauseexplicitly' of https://github.com/Spiri…

55e7bbb

…tZhou/keda into spiritzhou/pauseexplicitly

Update

72d48cf

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested review from zroubalik and JorTurFer July 21, 2023 01:41

SpiritZhou added 2 commits July 27, 2023 10:07

Merge branch 'main' into spiritzhou/pauseexplicitly

1241f09

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

e041471

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Merge branch 'main' into spiritzhou/pauseexplicitly

3c18bb6

Merge branch 'main' into spiritzhou/pauseexplicitly

33c9083

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested a review from tomkerkhove September 6, 2023 05:52

zroubalik reviewed Sep 6, 2023

View reviewed changes

apis/keda/v1alpha1/scaledobject_types.go Outdated Show resolved Hide resolved

apis/keda/v1alpha1/scaledobject_types.go Show resolved Hide resolved

Update

d66c39b

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested a review from zroubalik September 7, 2023 02:18

tomkerkhove approved these changes Sep 11, 2023

View reviewed changes

tomkerkhove assigned zroubalik and JorTurFer Sep 11, 2023

zroubalik approved these changes Sep 11, 2023

View reviewed changes

JorTurFer reviewed Sep 11, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

2694b09

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

zroubalik approved these changes Sep 13, 2023

View reviewed changes

Merge branch 'main' into spiritzhou/pauseexplicitly

dd8a5a1

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

zroubalik approved these changes Sep 25, 2023

View reviewed changes

zroubalik enabled auto-merge (squash) September 25, 2023 07:58

zroubalik merged commit fc3f31c into kedacore:main Sep 25, 2023
18 checks passed

zroubalik mentioned this pull request Oct 6, 2023

add pause metric in prometheus for scaledobject #5045

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide explicitly pausing annotations of ScaledObjects at the current replica count #4809

Provide explicitly pausing annotations of ScaledObjects at the current replica count #4809

SpiritZhou commented Jul 18, 2023 •

edited by tomkerkhove

Loading

github-actions bot commented Jul 18, 2023

tomkerkhove left a comment

tomkerkhove commented Jul 18, 2023 •

edited by github-actions bot

Loading

tomkerkhove left a comment

SpiritZhou commented Jul 20, 2023

JorTurFer commented Jul 26, 2023 •

edited by github-actions bot

Loading

SpiritZhou commented Jul 27, 2023

JorTurFer commented Jul 27, 2023

zroubalik commented Sep 5, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Sep 6, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Sep 8, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Sep 8, 2023

SpiritZhou commented Sep 11, 2023

tomkerkhove left a comment

tomkerkhove commented Sep 11, 2023

zroubalik left a comment

JorTurFer left a comment

zroubalik left a comment

SpiritZhou commented Sep 25, 2023

zroubalik commented Sep 25, 2023 •

edited by github-actions bot

Loading

Provide explicitly pausing annotations of ScaledObjects at the current replica count #4809

Provide explicitly pausing annotations of ScaledObjects at the current replica count #4809

Conversation

SpiritZhou commented Jul 18, 2023 • edited by tomkerkhove Loading

Checklist

github-actions bot commented Jul 18, 2023

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove commented Jul 18, 2023 • edited by github-actions bot Loading

tomkerkhove left a comment

Choose a reason for hiding this comment

SpiritZhou commented Jul 20, 2023

JorTurFer commented Jul 26, 2023 • edited by github-actions bot Loading

SpiritZhou commented Jul 27, 2023

JorTurFer commented Jul 27, 2023

zroubalik commented Sep 5, 2023 • edited by github-actions bot Loading

tomkerkhove commented Sep 6, 2023 • edited by github-actions bot Loading

tomkerkhove commented Sep 8, 2023 • edited by github-actions bot Loading

tomkerkhove commented Sep 8, 2023

SpiritZhou commented Sep 11, 2023

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove commented Sep 11, 2023

zroubalik left a comment

Choose a reason for hiding this comment

JorTurFer left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

SpiritZhou commented Sep 25, 2023

zroubalik commented Sep 25, 2023 • edited by github-actions bot Loading

SpiritZhou commented Jul 18, 2023 •

edited by tomkerkhove

Loading

tomkerkhove commented Jul 18, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Jul 26, 2023 •

edited by github-actions bot

Loading

zroubalik commented Sep 5, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Sep 6, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Sep 8, 2023 •

edited by github-actions bot

Loading

zroubalik commented Sep 25, 2023 •

edited by github-actions bot

Loading