Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Azure Log Analytics scaler documentation #250

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Added Azure Log Analytics scaler documentation #250

merged 3 commits into from
Sep 10, 2020

Conversation

spoplavskiy
Copy link
Contributor

This PR is a documentation for Log Analytics scaler.
Code: 1085
Issue: 1061

Signed-off-by: Sergiy Poplavskyi spopla@microsoft.com

Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request for the fromenvs but for the rest it looks great, thanks!

content/docs/2.0/scalers/azure-log-analytics.md Outdated Show resolved Hide resolved
…nv' feature.

Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
@tomkerkhove
Copy link
Member

Thanks so much @spoplavskiy and sorry for all the detailed changes!

@spoplavskiy
Copy link
Contributor Author

Thanks so much @spoplavskiy and sorry for all the detailed changes!

@tomkerkhove , no worries, it is a better to have a proper doc now, than receive a bugs in a future :)

@tomkerkhove tomkerkhove merged commit 35a5b4e into kedacore:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants