Added Azure Log Analytics scaler documentation

[spoplavskiy]

Signed-off-by: Sergiy Poplavskyi spopla@microsoft.com

Relates to kedacore/keda#1061

[tomkerkhove]

Added a bunch of first comments but high-level looks fine, thanks!

[tomkerkhove]

I'm wondering - Do we use in-line queries, use config map or mount them on the scaled workload?

[tomkerkhove]

Thoughts @zroubalik @ahmelsayed ?

[spoplavskiy]

@tomkerkhove , I used Prometheus Scaler as reference: https://keda.sh/docs/1.5/scalers/prometheus/

[tomkerkhove]

Makes sense but in this case, they are a bit longer. It's ok for me but just want to verify with the others.

[ahmelsayed]

You can define a multi-line string in yaml using

      ...
      query: |
        let AppName = "web";
        let ClusterName = "demo-cluster";
        let AvgDuration = ago(10m);
        let ThresholdCoefficient = 0.8;
        Perf
        | where InstanceName contains AppName
        | where InstanceName contains ClusterName
        | where CounterName == "cpuUsageNanoCores"
        | where TimeGenerated > AvgDuration
        | extend AppName = substring(InstanceName, indexof((InstanceName), "/", 0, -1, 10) + 1)
        | summarize MetricValue=round(avg(CounterValue)) by CounterName, AppName
        | join (Perf 
                | where InstanceName contains AppName
                | where InstanceName contains ClusterName
                | where CounterName == "cpuLimitNanoCores"
                | where TimeGenerated > AvgDuration
                | extend AppName = substring(InstanceName, indexof((InstanceName), "/", 0, -1, 10) + 1)
                | summarize arg_max(TimeGenerated, *) by AppName, CounterName
                | project Limit = CounterValue, TimeGenerated, CounterPath, AppName)
                on AppName
        | project MetricValue, Threshold = Limit * ThresholdCoefficient

which might make it look a bit more readable.

[tomkerkhove]

Love the suggestion!

[tomkerkhove]

LGTM, but allowing others to comment as well.

[tomkerkhove]

Makes sense but in this case, they are a bit longer. It's ok for me but just want to verify with the others.

[tomkerkhove]

LGTM, but want your input on some topics @zroubalik @ahmelsayed .

[tomkerkhove]

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft#L15 with your new scaler please? Thanks!

[spoplavskiy]

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft#L15 with your new scaler please? Thanks!

@tomkerkhove , thanks for pointing. Added in last commit.

[zroubalik]

@spoplavskiy one last thing, DCO please :)

[tomkerkhove]

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

[spoplavskiy]

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

@tomkerkhove, Changed query to multiline in last commit

[spoplavskiy]

@tomkerkhove, @zroubalik It looks like command, suggested by DCO tool to sign-off all my commits produced unexpected result :) It it now hard to revert and find in git log all my commits, as many of them was just applying inline suggections.

What if we finish reviewing this PR, and I will close this and open a new one by forking last version and applying my changes in single signed commit? Is that OK?

[tomkerkhove]

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

[spoplavskiy]

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

@tomkerkhove , I have created a new PR: #250