Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Azure Pipelines Scaler doc #411

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

troydn
Copy link
Contributor

@troydn troydn commented Mar 30, 2021

This PR adds documentation for Azure Pipelines Scaler.

Relates to kedacore/keda#1705

Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn troydn force-pushed the azure_pipelines_scaler_docs branch from e4eeb53 to cac36ab Compare March 30, 2021 18:59
@tomkerkhove
Copy link
Member

Thank you, I'll review ASAP!

Signed-off-by: Troy <troydenorme@hotmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few editorial suggestions though.

content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
content/docs/2.3/scalers/azure-pipelines.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for the feature PR to be merged!

@troydn troydn force-pushed the azure_pipelines_scaler_docs branch from e7093bd to 27c7752 Compare March 31, 2021 19:00
troydn and others added 2 commits March 31, 2021 21:20
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Troy <troydenorme@hotmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Troy <troydenorme@hotmail.com>
@troydn troydn force-pushed the azure_pipelines_scaler_docs branch from 27c7752 to 3adba8d Compare March 31, 2021 19:21
Signed-off-by: Troy <troydenorme@hotmail.com>
@tomkerkhove
Copy link
Member

@troydn I think this is a solid case for a blog post talking about it end-to-end. Are you willing to write one that we publish on keda.sh where a self-hosted agent is deployed and we add autoscaling to it?

@troydn
Copy link
Contributor Author

troydn commented Apr 8, 2021

@troydn I think this is a solid case for a blog post talking about it end-to-end. Are you willing to write one that we publish on keda.sh where a self-hosted agent is deployed and we add autoscaling to it?

@tomkerkhove Yes, I could write one. Should I create a seperate PR for this?

@tomkerkhove
Copy link
Member

A seperate PR would be great, thanks!

What I was thinking about was:

  • Deploy self-hosted agent
  • Schedule some pipeline runs
  • Apply autoscaling
  • Show outcome
    Would that make sense to you?

@tomkerkhove tomkerkhove merged commit 5bd35fe into kedacore:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants