add Azure Pipelines Scaler

[troydn]

Add a new Azure Pipelines Scaler

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
  - [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable) (add Azure Pipelines Scaler doc keda-docs#411)
• Changelog has been updated

Relates to #1705

[tomkerkhove]

Thanks a ton @troydn, this is great!

[zroubalik]

Looking good, minor comment!

[zroubalik]

LGTM, thanks @troydn

Would be nice if you could add e2e test for this scaler.
https://github.com/kedacore/keda/tree/main/tests

[troydn]

LGTM, thanks @troydn

Would be nice if you could add e2e test for this scaler.
https://github.com/kedacore/keda/tree/main/tests

I can add e2e tests for this scaler but this would require an Azure DevOps organization that can be used for the e2e tests. Should I create one and provide the details/access or would you rather provide one?

[tomkerkhove]

I can set one up, what do you need? Org id and PAT?

[tomkerkhove]

And what PAT permissions?

[zroubalik]

@tomkerkhove great, just to be sure, we will need something pernament once the tests are ready. Mabye @jeffhollan or @ahmelsayed could help with that?

[tomkerkhove]

They are free so should be OK!

[tomkerkhove]

Org created as per kedacore/governance#20 and is up on https://dev.azure.com/kubernetes-event-driven-autoscaling/Kubernetes%20Event-driven%20Autoscaling%20(KEDA)

[troydn]

Org created as per kedacore/governance#20 and is up on https://dev.azure.com/kubernetes-event-driven-autoscaling/Kubernetes%20Event-driven%20Autoscaling%20(KEDA)

Thanks!
Should the e2e test also manage the creation of the build definition and the agent pool on Azure DevOps? It could also be a one time setup where an empty agent pool is created and a simple build definition is created that sleeps for 2 minutes.

[tomkerkhove]

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.

What else do you need in terms of config and what PAT permissions are required?

[troydn]

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.

What else do you need in terms of config and what PAT permissions are required?

I finished the e2e test. But I'm not sure what image should be used for the Azure DevOps Agent. For now, I used one on my docker registry. But I think this should be replaced by one on a registry managed by KEDA.

The test requires an Azure DevOps environment with the following config:

• Agent pool created
• A pipeline configured to run on the created agent pool with "sleep 2m" as build step
• A PAT with the following permissions:
  • Agent Pools : Read & manage
  • Build: Read & execute

[tomkerkhove]

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.
What else do you need in terms of config and what PAT permissions are required?

I finished the e2e test. But I'm not sure what image should be used for the Azure DevOps Agent. For now, I used one on my docker registry. But I think this should be replaced by one on a registry managed by KEDA.

We host all test images on https://github.com/kedacore/test-tools, are you OK in adding a container image there?

The test requires an Azure DevOps environment with the following config:

• Agent pool created

• A pipeline configured to run on the created agent pool with "sleep 2m" as build step

• A PAT with the following permissions:

  • Agent Pools : Read & manage
  • Build: Read & execute

I'll get this setup tomorrow.

[tomkerkhove]

@troydn I've added these GitHub secrets for you:

Pipeline is up on https://dev.azure.com/kubernetes-event-driven-autoscaling/Kubernetes%20Event-driven%20Autoscaling%20(KEDA)/_build?definitionId=1 with PR open on kedacore/test-tools#11

Feel free to let me know if you're missing something.

[troydn]

@tomkerkhove thanks for your help on this. I think the e2e test is ready now.

[tomkerkhove]

LGTM, can you just fix the merge conflict please?

[tomkerkhove]

Thank you @troydn and let me know if you are interested for the blog post! (kerkhove.tom@gmail.com)