Cron: adding note for improvement #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Ritikaa96
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
reviewed
Aug 18, 2021
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
@tomkerkhove Changed the note as suggested. PTAL and let me know if any other change is needed. |
tomkerkhove
approved these changes
Aug 18, 2021
5 tasks
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
@tomkerkhove shifted the note after all parameters. PTAL. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ritikaa96 ritika@india.nec.com
Description
Adding Note for valid start and end inputs in Cron scaler as mentioned in this comment here
Checklist
Fixes #2031