-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validation and check in cron scaler for same start and end case #2032
validation and check in cron scaler for same start and end case #2032
Conversation
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@zroubalik @ahmelsayed PTAL |
I'd add a note to the docs here (https://github.com/kedacore/keda-docs/blob/master/content/docs/2.5/scalers/cron.md) about this error case. @tomkerkhove what do you think? |
Agreed! Let's add it to all versions where CRON is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ritikaa96 looking good, could you please add a note to the Changelog (Improvements section) and add note to the docs as @ahmelsayed mentioned. Thanks!
Sure @zroubalik. Working on it. |
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@zroubalik @ahmelsayed @tomkerkhove |
Thanks @Ritikaa96 |
…core#2032) Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Signed-off-by: Ritikaa96 ritika@india.nec.com
Provide a description of what has been changed
In corn scaler, the target doesn't scale down when the start and end schedule are given the same input.
Checklist
Fixes #2031