Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding corsHeader documentation for keda issue #2884 #749

Merged
merged 2 commits into from
Apr 21, 2022
Merged

adding corsHeader documentation for keda issue #2884 #749

merged 2 commits into from
Apr 21, 2022

Conversation

xphyr
Copy link
Contributor

@xphyr xphyr commented Apr 20, 2022

Signed-off-by: Mark DeNeve xphyr@users.noreply.github.com

Small documentation update for ActiveMQ and Artemis documentation to call out the CoreHeader configuration item. This documentation change addresses the new configuration item "corsHeader" that is a part of the ActiveMQ scaler, and adds documentation for the existing Artemis configuration item of the same name.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes # Keda Issue #2884

Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit e8542ec
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62602877aa9cf90008c97147
😎 Deploy Preview https://deploy-preview-749--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xphyr
Copy link
Contributor Author

xphyr commented Apr 20, 2022

I just realized that I added this doc update to 2.7, without knowing where the change will be released. If the actual change will be in a point release of 2.6 let me know and I will add the change to the 2.6 docs as well.

@zroubalik
Copy link
Member

2.7 is the correct one.

Could you please update the artemis docs for the previous versions as well? (the cors header is present there).

Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
@xphyr
Copy link
Contributor Author

xphyr commented Apr 20, 2022

Could you please update the artemis docs for the previous versions as well? (the cors header is present there).

@zroubalik - Done. It appears that the corsHeader was added to Artemis back in release 2.3 so I have updated the docs going all the way back to 2.3. I also fixed a small formatting error in the 2.7 docs where I had one two many spaces in the list.

@zroubalik zroubalik merged commit 10d4619 into kedacore:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants