Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CORS header to activemq scaler for issue #2884 #2924

Merged
merged 4 commits into from
Apr 21, 2022
Merged

adding CORS header to activemq scaler for issue #2884 #2924

merged 4 commits into from
Apr 21, 2022

Conversation

xphyr
Copy link
Contributor

@xphyr xphyr commented Apr 20, 2022

This PR addresses issue #2884 and adds CoreHeaders to ActiveMQ scaler queries using the same logic used by the the Artemis scaler in the activemq scaler.

Signed-off-by: Mark DeNeve xphyr@users.noreply.github.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [NA] Tests have been added
  • [NA] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (Keda Docs PR #749)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2884

…ssue #2884

using the same logic for origin header from the artemis scaler in the activemq scaler

Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
@xphyr xphyr requested a review from a team as a code owner April 20, 2022 13:39
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/activemq_scaler.go Show resolved Hide resolved
…t used in Artemis code.

Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the improvement, only one small nit inline

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
@zroubalik
Copy link
Member

zroubalik commented Apr 21, 2022

/run-e2e activemq*
Update: You can check the progres here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@zroubalik zroubalik merged commit 7513ffc into kedacore:main Apr 21, 2022
bamboo12366 pushed a commit to bamboo12366/keda that referenced this pull request Apr 30, 2022
…re#2924)

Signed-off-by: Mark DeNeve <xphyr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveMQ scaler does not work with CORS enabled
3 participants