Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document kafka partitionLimitation parameter #981

Merged
merged 2 commits into from
Dec 7, 2022
Merged

document kafka partitionLimitation parameter #981

merged 2 commits into from
Dec 7, 2022

Conversation

tobiaskrause
Copy link
Contributor

@tobiaskrause tobiaskrause commented Nov 18, 2022 •
edited by tomkerkhove
Loading

Signed-off-by: Tobias Krause tobias.krause@otto.de

Documentation of kedacore/keda#3879 Limit Kafka Partitions KEDA operates on

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3830

@tobiaskrause
document kafka partitionLimitation parameter
340172f 
Signed-off-by: Tobias Krause <tobias.krause@otto.de>
@netlify
Copy link

netlify bot commented Nov 18, 2022 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8c8a64a
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/637b2b87ce1a510007049f26
😎 Deploy Preview https://deploy-preview-981--keda.netlify.app/docs/2.8/scalers/apache-kafka
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tobiaskrause tobiaskrause mentioned this pull request Nov 18, 2022
Merged
4 tasks
@tobiaskrause tobiaskrause marked this pull request as ready for review November 18, 2022 14:27
@tobiaskrause tobiaskrause requested a review from a team as a code owner November 18, 2022 14:27
tomkerkhove
tomkerkhove approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

content/docs/2.8/scalers/apache-kafka.md Outdated Show resolved Hide resolved
@tobiaskrause @tomkerkhove
Update content/docs/2.8/scalers/apache-kafka.md
8c8a64a 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tobias Krause <tobiaskrause@users.noreply.github.com>
@zroubalik zroubalik merged commit 88caea1 into kedacore:main Dec 7, 2022
jeffhollan pushed a commit that referenced this pull request Dec 8, 2022
@tobiaskrause @tomkerkhove @jeffhollan
document kafka partitionLimitation parameter (#981)
8b5549a 
Signed-off-by: Tobias Krause <tobias.krause@otto.de>
Signed-off-by: Tobias Krause <tobiaskrause@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jeff Hollan <jeffhollan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiaskrause @tomkerkhove @zroubalik