Limit Kafka Partitions KEDA operates on #3879
Conversation
Signed-off-by: Tobias Krause <tobias.krause@otto.de>
Signed-off-by: Tobias Krause <tobias.krause@otto.de>
Signed-off-by: Tobias Krause <tobias.krause@otto.de>
There was a problem hiding this comment.
LGTM but I'm not kafka expert, WDYT about this feature @zroubalik ?
There was a problem hiding this comment.
Looking good, @tobiaskrause do you think you can add e2e test for this feature? Then we can go ahead and merge this. Thanks
https://github.com/kedacore/keda/tree/main/tests
|
We are going to release KEDA v2.9 on Thursday. Do you think you can add e2e tests by Wednesday @tobiaskrause? |
Not sure, to be honest. Till now I wasn't able to find a reliable way to send a message to a specific partition with the kafka-console-producer script. I would need a custom producer on a pod. Do you have any idea to solve this @tomkerkhove? |
|
/run-e2e kafka* |
There was a problem hiding this comment.
LGTM,
I think we can merge it without e2e test, as it is something not very easy testable. WDYT @tomkerkhove @JorTurFer ?
You are the kafka expert xD |
|
@JosephABC would you mind looking at this as well, since you are doing a Kafka PR in parallel? |
|
/run-e2e kafka* |
Signed-off-by: Tobias Krause <tobias.krause@otto.de> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Tobias Krause tobias.krause@otto.de
Limit Kafka Partitions KEDA operates on. #3830
Checklist
Relates to #3830
Relates to kedacore/keda-docs#981