Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Azure DevOps Server for Azure Pipelines #1919

Closed
Tracked by #1285
tomkerkhove opened this issue Jun 30, 2021 · 4 comments
Closed
Tracked by #1285

Support Azure DevOps Server for Azure Pipelines #1919

tomkerkhove opened this issue Jun 30, 2021 · 4 comments
Assignees
@v-shenoy
Labels
azure All issues concerning integration with Azure feature All issues for new features that have been committed to help wanted Looking for support from community

Comments

@tomkerkhove
Copy link
Member

Proposal

Support Azure DevOps Server for Azure Pipelines

Use-Case

No response

Anything else?

Relates to #1285
@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to labels Jun 30, 2021
@tomkerkhove tomkerkhove mentioned this issue Jun 30, 2021
Closed
10 tasks
@tomkerkhove tomkerkhove added azure All issues concerning integration with Azure feature All issues for new features that have been committed to help wanted Looking for support from community and removed feature-request All issues for new features that have not been committed to needs-discussion labels Jun 30, 2021
@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
@v-shenoy v-shenoy self-assigned this Mar 29, 2022
@JorTurFer
Copy link
Member

This PR looks like a good place for refactoring the code and remove duplications related with supporting non-public clouds in other scalers, WDYT @v-shenoy ?

@v-shenoy
Copy link
Contributor

This PR looks like a good place for refactoring the code and remove duplications related with supporting non-public clouds in other scalers, WDYT @v-shenoy ?

Yup, sounds good.

@tomkerkhove tomkerkhove moved this from To Do to In Progress in Roadmap - KEDA Core Mar 30, 2022
@v-shenoy
Copy link
Contributor

v-shenoy commented Apr 1, 2022 •
edited
Loading

I installed my own DevOps server on an Azure VM with Azure DevOps Express following the instructions here and here.

The scaler is able to fetch metrics when provided with the PAT and the appropriate server URL / bindings configured during the setup, and scaling works as intended. No changes need to be done to support them.

@JorTurFer @tomkerkhove

Just going to send a PR with the refactoring for active directory endpoints, if that is alright?

@v-shenoy
Copy link
Contributor

v-shenoy commented Apr 1, 2022 •
edited
Loading

Raised a PR with the refactored changes. As for this issue, I think this should be closed now (along with the umbrella issue).

Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Apr 1, 2022
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Apr 1, 2022
@JorTurFer JorTurFer moved this from Done to Ready To Ship in Roadmap - KEDA Core Apr 1, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-shenoy v-shenoy

Labels
azure All issues concerning integration with Azure feature All issues for new features that have been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomkerkhove @JorTurFer @v-shenoy