Support non-public clouds for Microsoft Azure

[djj0809]

The resource name and the queue endpoint suffix should be configurable in triggers.

keda/pkg/scalers/azure/azure_storage.go

Lines 34 to 64 in 57ffd4e

	func ParseAzureStorageQueueConnection(podIdentity, connectionString, accountName string) (azqueue.Credential, *url.URL, error) {
	switch podIdentity {
	case "azure":
	token, err := GetAzureADPodIdentityToken("https://storage.azure.com/")
	if err != nil {
	return nil, nil, err
	}
	if accountName == "" {
	return nil, nil, fmt.Errorf("accountName is required for podIdentity azure")
	}
	credential := azqueue.NewTokenCredential(token.AccessToken, nil)
	endpoint, _ := url.Parse(fmt.Sprintf("https://%s.queue.core.windows.net", accountName))
	return credential, endpoint, nil
	case "", "none":
	endpoint, accountName, accountKey, err := parseAzureStorageConnectionString(connectionString, QueueEndpoint)
	if err != nil {
	return nil, nil, err
	}
	credential, err := azqueue.NewSharedKeyCredential(accountName, accountKey)
	if err != nil {
	return nil, nil, err
	}
	return credential, endpoint, nil
	default:
	return nil, nil, fmt.Errorf("azure queues doesn't support %s pod identity type", podIdentity)
	}
	}

Task List

• Support non-public clouds for Azure Storage Blob #1921
• Support non-public clouds for Azure Log Analytics #1916
• Support non-public clouds for Azure Event Hub #1915
• Support non-public clouds for Azure Monitor #1917
• Support non-public clouds for Azure Service Bus #1918
• Support non-public clouds for Azure Storage Queue #1920
• Support Azure DevOps Server for Azure Pipelines #1919
• Support non-public clouds for Azure Key Vault authentication #2733
• Support non-public clouds for Azure Data Explorer #2734
• Support non-public clouds for Azure Application Insights #2735

[zroubalik]

@djj0809 are you willing to contribute this?

[djj0809]

Would like to, however I’m not quite familiar with go projects... Zbynek Roubalik <notifications@github.com>于2020年10月23日 周五19:52写道：

…

@djj0809 <https://github.com/djj0809> are you willing to contribute this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1285 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIHCZF7RAIVAM4DYFMOZXTSMFVA3ANCNFSM4S4F2IKA> .

[tomkerkhove]

Might be something interesting for @ahmelsayed @jeffhollan

[JonasMatos0]

Hi, @djj0809 .

Can you please detail with examples what are the changes related to the Azure National clouds that are not supported on current scaler config implementation?

I'm planning on helping on this issues as soon as I get these details.

[tomkerkhove]

Thank you @amirschw!

[tomkerkhove]

Re-opening as we didn't cover all Azure scalers yet I think

[amirschw]

Indeed. Left to cover:

• Azure Event Bub
• Azure Log Analytics
• Azure Monitor
• Azure Service Bus

Azure Pipelines is only supported in public cloud AFAIK, so it's probably out of scope.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[tomkerkhove]

/keep-alive

This is still on-going

[v-shenoy]

I can take these up.