Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor active directory endpoint parsing for Azure scalers. #2853

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Refactor active directory endpoint parsing for Azure scalers. #2853

merged 3 commits into from
Apr 1, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 1, 2022 •
edited
Loading

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Refactor active directory endpoint parsing for Azure scalers.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #1285

@v-shenoy
Refactor active directory endpoint parsing for Azure scalers.
89420ba 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner April 1, 2022 08:11
@v-shenoy
Update CHANGELOG.
c8edba6 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Add tests.
e2d806c 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy mentioned this pull request Apr 1, 2022
Closed
JorTurFer
JorTurFer approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks for this improvement!

@JorTurFer JorTurFer merged commit b96adce into kedacore:main Apr 1, 2022
@v-shenoy v-shenoy deleted the pipelines-server branch April 1, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-shenoy @tomkerkhove @JorTurFer