Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review logger initialization on every scaler #3947

Closed
JorTurFer opened this issue Dec 2, 2022 · 1 comment · Fixed by #4022
Closed

Review logger initialization on every scaler #3947

JorTurFer opened this issue Dec 2, 2022 · 1 comment · Fixed by #4022
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Dec 2, 2022 •
edited
Loading

Report

After the changes in the logging inside scalers, there were 2 scalers which generate panic due to a mistake in the initialization. We should review all the scalers to ensure no more panics are thrown because this release in next release.
@JorTurFer JorTurFer added the bug Something isn't working label Dec 2, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Dec 2, 2022
@JorTurFer JorTurFer mentioned this issue Dec 2, 2022
Merged
2 tasks
@tomkerkhove
Copy link
Member

Thanks! Let's make sure we have this in the "new scaler" docs as well, if need be.

@JorTurFer JorTurFer added the good first issue Good for newcomers label Dec 9, 2022
@dttung2905 dttung2905 mentioned this issue Dec 17, 2022
Merged
2 tasks
JorTurFer pushed a commit that referenced this issue Dec 18, 2022
@dttung2905
fix: Logging for cpu memory scaler (#4022)
34c2614 
Fixes #3947
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Dec 18, 2022
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Logging for cpu memory scaler dttung2905/keda
2 participants
@tomkerkhove @JorTurFer