Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logging for cpu memory scaler #4022

Merged
merged 2 commits into from
Dec 18, 2022

Conversation

dttung2905
Copy link
Contributor

I did a scan through all existing scalers and found out cpu_memory_scaler has the same issue, hence I create this MR to fix the initialization of logger

Checklist

Fixes #3947

Relates to #

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner December 17, 2022 08:25
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
In CPU and memory scalers isn't strictly required as they don't use the logger internally without passing it (those scalers only use the logger during the parsing).
Just in case, I'll merge for the sake of the consistency

@JorTurFer JorTurFer enabled auto-merge (squash) December 18, 2022 20:29
@JorTurFer JorTurFer merged commit 34c2614 into kedacore:main Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review logger initialization on every scaler
2 participants