RabbitMQ Scalers -issues in connecting with TLS enabled

[maverickmetro]

When we have a TLS enabled Rabbit MQ service hosted in the cloud, Rabbit MQ scaler is not able to connect to the Rabbit MQ host Receiving the below error in Keda Operator API service pod . In Rabbit MQ Scaler i used the apiHost parameter with https protocol.

E0803 23:09:48.173311       1 provider.go:94] keda_metrics_adapter/provider "msg"="error getting metric for scaler" "error"="error inspecting rabbitMQ: Get \"https://ibm_cloud_26d26b44_4a05_4a02_a7fd_3423c5f6a4f7:***@a5adefe4-8087-450a-83c9-113f3de3b9b0.8117147f814b4b2ea643610826cd2046.databases.appdomain.cloud:30347/api/queues/%2F/KedaTestQueue\": x509: certificate signed by unknown authority"  "ScaledObject.Name"="keda-sample" "ScaledObject.Namespace"="default" "Scaler"={}
E0803 23:09:48.173371       1 status.go:71] apiserver received an error that is not an metav1.Status: &errors.errorString{s:"No matching metrics found for queuelength"}

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

1. Install Rabbit MQ with TLS enabled
2. Install Keda
3. Configure Rabbit MQ scaler scaled object to use apiHost Parameter with https protocol.

Sample Scaled Object Yaml:

apiVersion: v1
kind: Secret
metadata:
  name: rabbitmq-consumer-secret
data:
  RabbitHttpHost: xxxxxxxxxxx #https://XXXXXXXXXXXXX
---
apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
  name: keda-sample
  namespace: default
  labels:
    deploymentName: keda-sample
spec:
  scaleTargetRef:
    deploymentName: keda-sample
  pollingInterval: 5 # Optional. Default: 30 seconds
  cooldownPeriod: 30 # Optional. Default: 300 seconds
  minReplicaCount: 1
  maxReplicaCount: 5 # Optional. Default: 100
  triggers:
    - type: rabbitmq
      metadata:
        includeUnacked: "true"
        queueName: KedaTestQueue
        queueLength: "5"
        
      authenticationRef:
        name: rabbitmq-consumer-trigger
---
apiVersion: keda.k8s.io/v1alpha1
kind: TriggerAuthentication
metadata:
  name: rabbitmq-consumer-trigger
  namespace: default
spec:
  secretTargetRef:
    - parameter: apiHost
      name: rabbitmq-consumer-secret
      key: RabbitHttpHost

---

Specifications

• KEDA Version: 1.5.0
• Platform & Version: IBM public Cloud
• Kubernetes Version: 1.15.12
• Scaler(s): RabbitMQ Scaler

// EDIT: fixed formating (Zbynek)

[zroubalik]

I have done a quick check and RabbitMQ Scaler TLS support is not implemented yet. https://github.com/kedacore/keda/blob/v2/pkg/scalers/rabbitmq_scaler.go#L138 this would need to use amq.DialTLS(). And consume the ceritficate the similar way it has been done for example in Kafka Scaler.

@maverickmetro is this something you are willing to contribute?

[ansonauhk]

Please review, I submitted a fix
code - #1051
doc - kedacore/keda-docs#240

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed due to inactivity.

[debu99]

Why this is solved? i didn't see the code merge

[mohite-abhi]

I have added tls support for RabbitMQ getting inspiration from above MR, it's working for me. I would like to add it with Keda code. Can we reopen this issue, or should I create a new issue regarding it?

[mohite-abhi]

this issue is tracking some other closed pr when it should have been closed by #4086 merge.