Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #1091

Closed
wants to merge 1 commit into from
Closed

Update CHANGELOG.md #1091

wants to merge 1 commit into from

Conversation

ansonauhk
Copy link

@ansonauhk ansonauhk commented Sep 6, 2020

Update change log for #1073
Signed-off-by: Anson Au ansonau@gmail.com

Checklist

Relates to #967

Update change log for kedacore#1073
Signed-off-by: Anson Au ansonau@gmail.com
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you fix the DCO issues please?

@ansonauhk
Copy link
Author

LGTM, but can you fix the DCO issues please?

Tried but face an error. Any idea?

(base) Ansons-MBP:keda anson$ git commit --amend --signoff
[patch-1 1e26138] Update CHANGELOG.md
Author: Anson Au ansonauhk@users.noreply.github.com
Date: Sun Sep 6 20:01:27 2020 +0800
1 file changed, 1 insertion(+)
(base) Ansons-MBP:keda anson$ git push --force-with-lease origin patch-1
remote: Permission to kedacore/keda.git denied to ansonauhk.
fatal: unable to access 'https://github.com/kedacore/keda.git/': The requested URL returned error: 403

@zroubalik
Copy link
Member

zroubalik commented Sep 7, 2020

@ansonauhk could you give us output of:

git remote -v

You are trying to push to keda repo and not to your fork.

@ansonauhk
Copy link
Author

Will open new one to fix DCO

@ansonauhk ansonauhk closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants