-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenStack Metrics scaler #1692
Add OpenStack Metrics scaler #1692
Conversation
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
96b04a0
to
97d58af
Compare
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you been thinking about adding e2e test for this scaler?
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Hi @zroubalik, yes! I'm working within @pdominguite, I have already done some manually and I'm gonna start working on keda e2e tests for this scaler soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Provide a description of what has been changed
Add new scaler, Openstack Metrics Scaler
Signed-off-by: rodolfodc r.costa@sidi.org.br
Checklist
Related to #1382