Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStack metrics scaler doc #405

Closed
wants to merge 25 commits into from

Conversation

Rodolfodc
Copy link
Contributor

@Rodolfodc Rodolfodc commented Mar 19, 2021

Signed-off-by: rodolfodc r.costa@sidi.org.br

Add Openstack metrics scaler documenting (previously this scaler would be Openstack AODH scaler, but call it openstack metric scaler fits better its purpose.

This PR adds documentation for OpenStack Metric scaler.

PR for the scaler can be found at kedacore/keda#1462.

Relates to kedacore/keda#1342.

@Rodolfodc Rodolfodc closed this Mar 19, 2021
@Rodolfodc Rodolfodc reopened this Mar 22, 2021
@tomkerkhove
Copy link
Member

Is it me or is the diff empty?

@Rodolfodc
Copy link
Contributor Author

Rodolfodc commented Mar 24, 2021

You are right! I'm gonna check what happened. Thanks!

content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
@Rodolfodc Rodolfodc force-pushed the aodh_scaler_doc branch 2 times, most recently from ca84ab1 to db75aa9 Compare March 24, 2021 21:42
@Rodolfodc Rodolfodc requested a review from tomkerkhove March 24, 2021 23:23
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for the feature to merge

content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
content/docs/2.2/scalers/openstack-metric.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the content to content/docs/2.3/ ?

@zroubalik zroubalik changed the title Add Openstack metrics scaler doc Add OpenStack metrics scaler doc Mar 26, 2021
tomkerkhove and others added 11 commits March 26, 2021 15:06
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
* Update V1 Install docs

Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

* Update content/docs/1.4/deploy.md

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

* Update 1.5.0 docs

Signed-off-by: Pragna Gopa <pgopa@microsoft.com>

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Karg <rkarg@blizzard.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
…calculations (kedacore#398)

Signed-off-by: Ty Brown <tbrown@rewardsnetwork.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
* docs: Provide overview of required ports to be accessible

Relates to https://github.com/kedacore/keda/discussions/1634
Closes kedacore#384

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Add port details

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: Joe Shearn <joseph.shearn@sainsburys.co.uk>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: marpio <marcinkowski@mailbox.org>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
… blog post (kedacore#408)

* Provide "Migrating our container images to Github Container Registry" blog post

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* PR feedback

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>

Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Rodolfodc and others added 14 commits March 26, 2021 15:06
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
Signed-off-by: rodolfodc <r.costa@sidi.org.br>
@Rodolfodc
Copy link
Contributor Author

Rodolfodc commented Mar 26, 2021

Hi @zroubalik, I made a mistake while rebasing and I found out that it would be better if I created a new branch! I closed this PR and opened this another one. Sorry for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants