Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app.kubernetes.io/version label from label selectors #1696

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Remove app.kubernetes.io/version label from label selectors #1696

merged 5 commits into from
Mar 24, 2021

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Mar 23, 2021 •
edited
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #1694

@anggao
Remove app.kubernetes.io/version label from label selectors
785b643 
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
@anggao anggao force-pushed the fix-label-selector branch from 8de8507 to 785b643 Compare March 23, 2021 16:19
@anggao
update Changelog
badae68 
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
zroubalik
zroubalik reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks.

Just need to add comments for this change

Makefile Show resolved Hide resolved
config/default/kustomization.yaml Show resolved Hide resolved
@anggao
add comments
f3bf8a8 
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
@anggao anggao force-pushed the fix-label-selector branch from 4cfbde2 to f3bf8a8 Compare March 24, 2021 11:24
anggao added 2 commits March 24, 2021 11:31
@anggao
fix format
7200e44 
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
@anggao
remove app.kubernetes.io/part-of from selector
ae0d5bb 
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
zroubalik
zroubalik approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit dfdcc5e into kedacore:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should remove app.kubernetes.io/version label from label selectors
2 participants
@anggao @zroubalik