Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app.kubernetes.io/version label from label selectors #1696

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Remove app.kubernetes.io/version label from label selectors #1696

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
785b643
Remove app.kubernetes.io/version label from label selectors
anggao Mar 23, 2021
badae68
update Changelog
anggao Mar 23, 2021
f3bf8a8
add comments
anggao Mar 24, 2021
7200e44
fix format
anggao Mar 24, 2021
ae0d5bb
remove app.kubernetes.io/part-of from selector
anggao Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

### Improvements

- TODO ([#XXX](https://github.com/kedacore/keda/pull/XXXX))
- Remove app.kubernetes.io/version label from label selectors ([#1696](https://github.com/kedacore/keda/pull/1696))

### Breaking Changes

Expand Down
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ release: manifests kustomize set-version
$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda=${IMAGE_CONTROLLER}
cd config/metrics-server && \
$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-metrics-apiserver=${IMAGE_ADAPTER}
cd config/default && \
$(KUSTOMIZE) edit add label -f app.kubernetes.io/version:${VERSION}
@sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/default/kustomize-config/metadataLabelTransformer.yaml
rm -rf config/default/kustomize-config/metadataLabelTransformer.yaml.out
$(KUSTOMIZE) build config/default > keda-$(VERSION).yaml

.PHONY: set-version
Expand Down Expand Up @@ -122,8 +122,8 @@ deploy: manifests kustomize
$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda=${IMAGE_CONTROLLER}
cd config/metrics-server && \
$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-metrics-apiserver=${IMAGE_ADAPTER}
cd config/default && \
$(KUSTOMIZE) edit add label -f app.kubernetes.io/version:${VERSION}
@sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/default/kustomize-config/metadataLabelTransformer.yaml
anggao marked this conversation as resolved.
Show resolved Hide resolved
rm -rf config/default/kustomize-config/metadataLabelTransformer.yaml.out
$(KUSTOMIZE) build config/default | kubectl apply -f -

# Undeploy controller
Expand Down
4 changes: 2 additions & 2 deletions config/default/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
commonLabels:
app.kubernetes.io/part-of: keda-operator
app.kubernetes.io/version: main

transformers:
anggao marked this conversation as resolved.
Show resolved Hide resolved
- kustomize-config/metadataLabelTransformer.yaml

resources:
- ../crd
Expand Down
9 changes: 9 additions & 0 deletions config/default/kustomize-config/metadataLabelTransformer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: builtin
kind: LabelTransformer
metadata:
name: metadataLabelTransformer
labels:
app.kubernetes.io/version: main
fieldSpecs:
- path: metadata/labels
create: true