Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce is-paused annotation for ScaledJobs #3656

Closed
wants to merge 0 commits into from
Closed

Introduce is-paused annotation for ScaledJobs #3656

wants to merge 0 commits into from

Conversation

keegancwinchester
Copy link

@keegancwinchester keegancwinchester commented Sep 9, 2022 •
edited
Loading

Signed-off-by: keegancwinchester 91917907+keegancwinchester@users.noreply.github.com

Introduce is-paused annotation for ScaledJobs

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #3303

@keegancwinchester keegancwinchester requested a review from a team as a code owner September 9, 2022 18:35
tomkerkhove
tomkerkhove reviewed Sep 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Would you mind filling in the checklist and open a PR for our docs please?

zroubalik
zroubalik reviewed Sep 12, 2022
View reviewed changes
apis/keda/v1alpha1/scaledjob_types.go Outdated Show resolved Hide resolved
pkg/scaling/executor/scale_jobs.go Outdated Show resolved Hide resolved
@keegancwinchester keegancwinchester mentioned this pull request Sep 12, 2022
Closed
1 task
@keegancwinchester
Copy link
Author

Added PR for docs: kedacore/keda-docs#932 @tomkerkhove

@tomkerkhove
Copy link
Member

How are things going, do you need any help @keegancwinchester?

@keegancwinchester
Copy link
Author

@tomkerkhove Trying to remedy the CI error :
func ``(*ScaledJobReconciler).stopScaleLoopWhenPaused is unused (unused)`

@JorTurFer
Copy link
Member

JorTurFer commented Oct 4, 2022 •
edited
Loading

@tomkerkhove Trying to remedy the CI error : func(*ScaledJobReconciler).stopScaleLoopWhenPaused `` is unused (unused)`

I have checkd your code and I can't see where you're using the function stopScaleLoopWhenPaused, I can see the definition but not the usage. The linting error is due to that

@keegancwinchester keegancwinchester force-pushed the feature/SJannotation branch 2 times, most recently from 97e5496 to a8b3e3f Compare October 24, 2022 18:14
@tomkerkhove
Copy link
Member

Sorry to see this @keegancwinchester - Let me know if you still want to contribute but need help

@keegancwinchester
Copy link
Author

@tomkerkhove was just trying to rebase and accidentally closed but i moved it to #3783

flux-benj added a commit to flux-benj/keda that referenced this pull request May 21, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
2fe8ba5 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: flux-benj <benjamin.jessop@fluxfederation.com>
@flux-benj flux-benj mentioned this pull request May 21, 2023
Merged
7 tasks
flux-benj added a commit to flux-benj/keda that referenced this pull request May 22, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
348f197 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request May 23, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
cf20ec6 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request May 23, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
a676efb 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 11, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
a99f8ea 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 18, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
356050d 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 18, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
24ecf33 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 21, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
2766aea 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 21, 2023
@flux-benj
feat: Provide support for explicitly pausing autoscaling of ScaledJobs
c1980b4 
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
zroubalik added a commit that referenced this pull request Jun 22, 2023
@flux-benj @zroubalik
feat: Provide support for explicitly pausing autoscaling of ScaledJobs (
d65e132 
#4558)

--- Accreditation ---

Original PR: #3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # #3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik mentioned this pull request Jun 22, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@tomkerkhove tomkerkhove tomkerkhove left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keegancwinchester @tomkerkhove @JorTurFer @zroubalik