Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide support for explicitly pausing autoscaling of ScaledJobs #3828

Closed

Conversation

keegancwinchester
Copy link

@keegancwinchester keegancwinchester commented Nov 7, 2022

Introduce paused annotation for scaledJobs

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3303

@keegancwinchester keegancwinchester requested a review from a team as a code owner November 7, 2022 16:52
Signed-off-by: keegancwinchester <keegan.winchester@shipt.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @keegancwinchester
I have to apologize for the super slow response :(
Your PR looking good, could you open an e2e test checking that this work as expected?

@@ -35,6 +35,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
- [v1.2.0](#v120)
- [v1.1.0](#v110)
- [v1.0.0](#v100)
- **General:** Introduce autoscaling is paused annotation for ScaledJobs ([#3303](https://github.com/kedacore/keda/issues/3303))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to new section, just above - General: Introduce new Loki Scaler

Comment on lines +338 to +340
// stopScaleLoop
return r.stopScaleLoop(ctx, logger, scaledJob)
//return r.scaleHandler.DeleteScalableObject(ctx, scaledJob)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete these comments?

@JorTurFer JorTurFer changed the title trying commit from fresh branch feat: Provide support for explicitly pausing autoscaling of ScaledJobs Nov 24, 2022
@tomkerkhove
Copy link
Member

We are going to release KEDA v2.9 on Thursday. Do you think you can complete the open work by Wednesday @keegancwinchester?

@keegancwinchester
Copy link
Author

@tomkerkhove apologies for late reply. will have this done by end of week

@tomkerkhove
Copy link
Member

No worries at all and thank you!

@tomkerkhove
Copy link
Member

Any update on this?

@wiseelf
Copy link

wiseelf commented Mar 9, 2023

What is the current status of this PR? I thought it would be in 2.10.0

@JorTurFer
Copy link
Member

Hi @keegancwinchester
Are you still willing to contribute with this? We can unassign the issue if you want

@sirantd
Copy link

sirantd commented Mar 16, 2023

When can it be expected? It would be advantageous to have this functionality.

@flux-benj
Copy link
Contributor

flux-benj commented May 3, 2023

Hey, any update on this? My org is adopting Keda for it's k8s environments and this is a key piece of functionality for deploying.

@flux-benj
Copy link
Contributor

👋 @JorTurFer

I'd love to get this functionality in to an upcoming release. Are you OK with others cherry-picking this MR and putting the finishing touches on @keegancwinchester's work? What would you deem the correct way to contribute to this feature?

@JorTurFer
Copy link
Member

I think that this PR is abandoned :(
There hasn't been any answer for 2 months, so I'll close it. @flux-benj go ahead if you are willing to do it

@JorTurFer JorTurFer closed this May 4, 2023
flux-benj added a commit to flux-benj/keda that referenced this pull request May 21, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: flux-benj <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request May 22, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request May 23, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request May 23, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 11, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 18, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 18, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 21, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj added a commit to flux-benj/keda that referenced this pull request Jun 21, 2023
--- Accreditation ---

Original PR: kedacore#3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # kedacore#3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
zroubalik added a commit that referenced this pull request Jun 22, 2023
#4558)

--- Accreditation ---

Original PR: #3828

Borrows from the work originally implemented by: https://github.com/keegancwinchester

Note: I would have loved to have pulled the commit from the original branch, but I could not be able to.

Documentation MR by original implementor: kedacore/keda-docs#932

--- Fixes ---

Fixes # #3656

--- PR Notes ---

Introduce annotation to pause ScaledJobs.

Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for explicitly pausing autoscaling of ScaledJobs
6 participants