fix: Replace $namepsace by $exported_namespace in keda-dashboard

[ganievs]

When The operator and s scaled objects are deployed in different namespaces, some metrics are not shown due to namespace labels conflict.

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

[JorTurFer]

This was solved in the chart directly: kedacore/charts@1a56c48
The problem was the serviceMonitor didn't honor namespaces, and that's why see the mismatch between them (and the extra label). If you add the flag to the serviceMonitor/podMonitor, is the problem solved?

[zroubalik]

I think we should also fix this here in the core repo, not just charts.

[JorTurFer]

In that case, we should rever the change in the helm repo. It exports these metrics, if we change them here, we should change the helm chart too

[zroubalik]

In that case, we should rever the change in the helm repo. It exports these metrics, if we change them here, we should change the helm chart too

@ganievs are you willing to do this?

[ganievs]

In that case, we should rever the change in the helm repo. It exports these metrics, if we change them here, we should change the helm chart too

@ganievs are you willing to do this?

Ok, will do that!

[ganievs]

A PR with changes in the chart repo: kedacore/charts#449

[zroubalik]

Could you please fix DCO? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work

[ganievs]

Signed

[zroubalik]

A PR with changes in the chart repo: kedacore/charts#449

@JorTurFer please confirm the chart PR is correct.

[tomkerkhove]

I'm not sure I get why honorLabels needs to be removed though?

[ganievs]

Hi folks! In my opinion, it will be better when the dashboard will follow a default Prometheus labeling behavior because it can be used not only with the initial Keda's helm chart or requirement to enable the honor labels should be mentioned in a documentation.

[JorTurFer]

I agree with the approach of using defaults.
I have already reviewed the chart changes, there is some feedback to be done there