Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add activation feature for cpu & memory scaler #6172

Closed
wants to merge 3 commits into from

Conversation

kunwooy
Copy link
Contributor

@kunwooy kunwooy commented Sep 18, 2024

Currently, the cpu & memory scalers lack the activation feature because they delegate the scaling responsibilities to the built-in Kubernetes HPA controller. As a result, even if the scale target is currently scaled-out by the cpu/memory metric being above the threshold value, if some other Keda scalers which use External Metrics are used in conjunction with the cpu/memory scaler, it will be deactivated (and thus scaled to zero) when all other scalers using External Metrics are deactivated.

Hence, my proposal is to introduce a way to check the activation of the cpu/memory scaler. Since the scaling behavior will be handled by the HPA controller, cpu/memory scaler only needs to feed in the activation value to the scaled object controller in its GetMetricsAndActivity() method. Moreover to enable such feature, I introduce activationValue field in cpu/memory trigger's metadata.

Checklist

Fixes #6057

Relates to #

@kunwooy kunwooy requested a review from a team as a code owner September 18, 2024 08:08
Signed-off-by: Kun Woo Yoo <vbtkdpf148@gmail.com>
Copy link

semgrep-app bot commented Sep 18, 2024

Semgrep found 2 context-todo findings:

Consider to use well-defined context

Ignore this finding from context-todo.

@kunwooy
Copy link
Contributor Author

kunwooy commented Sep 18, 2024

Semgrep found 2 context-todo findings:

Consider to use well-defined context

Ignore this finding from context-todo.

This is resolved

Signed-off-by: Kun Woo Yoo <vbtkdpf148@gmail.com>
Signed-off-by: Kun Woo Yoo <vbtkdpf148@gmail.com>
Copy link

semgrep-app bot commented Sep 18, 2024

Semgrep found 1 wrong-wrapped-error finding:

  • pkg/scalers/cpu_memory_scaler_test.go

Semgrep found a possible error wrong wrapped.

Ignore this finding from wrong-wrapped-error.

Copy link

semgrep-app bot commented Sep 19, 2024

Semgrep found 1 wrong-wrapped-error finding:

  • pkg/scalers/cpu_memory_scaler_test.go

Semgrep found a possible error wrong wrapped.

Ignore this finding from wrong-wrapped-error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant