Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps #6305

Merged
merged 23 commits into from
Nov 7, 2024
Merged

Bump deps #6305

merged 23 commits into from
Nov 7, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Nov 2, 2024 •
edited
Loading

This PR bumps all the dependencies:

  • golang: 1.23.3
  • kubernetes: 0.31.2
  • controller-runtime: v0.19.1
  • all the other packages
  • golangci-lint: v1.61.0
    • Fixed new detections: gosimple and govet

NOTE: I've opened PRs to the upstream dependencies. I will wait some days to see if those projects merge the PR and ship a release and I'll update this PR, if any of them doesn't do it, this PR is already using the branches that I use to open those PRs:

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

@JorTurFer JorTurFer requested a review from a team as a code owner November 2, 2024 21:22
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 2, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 3, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Nov 3, 2024
Closed
28 tasks
@smcavallo smcavallo mentioned this pull request Nov 3, 2024
Closed
4 tasks
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 3, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

JorTurFer and others added 17 commits November 6, 2024 09:29
@JorTurFer
bump workflow actions
85f7df6 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump aws
3230a43 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump k8s deps
961591d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump sigs.k8s.io/controller-tools
9c04431 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump more deps
5359382 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump golang version
f04f867 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
.
d5ed583 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump some deps
a2cdc0b 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump some deps
aa8b7dc 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump some deps
c1270e4 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update code-gen
f1e4e6f 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump golang version
83c2a48 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Update precommit and golangci-lint
a323dac 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
use cert-controller updated package
e49ea10 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Apply changes in from custom metrics apiserver
1cd62a8 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update mocks
ba291af 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
.
68bcc6b 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 6, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
bump go deps
64aa4a2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
bump github.com/golang-jwt/jwt/v4 to fix vulnerability
fba853a 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer mentioned this pull request Nov 6, 2024
Closed
7 tasks
@JorTurFer JorTurFer mentioned this pull request Nov 6, 2024
Merged
@JorTurFer
Add missing channel
2189066 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 6, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

JorTurFer and others added 3 commits November 7, 2024 08:28
@JorTurFer
bump golang versions
b9afde0 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update gomod
e68a4dd 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Merge branch 'main' into bump-deps
3205ca7
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 7, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 1267b12 into kedacore:main Nov 7, 2024
18 checks passed
@JorTurFer JorTurFer deleted the bump-deps branch November 7, 2024 09:37
@HeavyWombat
Copy link
Contributor

@JorTurFer Quick question, the go version is set to 1.23.3 with this PR. Was that on purpose? The minimum computed version is 1.22 based on a mingo run I did. If you want to force the version, I am wondering whether this would be better with a toolchain directive instead. Reason I ask is, because this version breaks on system, where the new Go version isn't available yet. With toolchain set, I can still control it via the toolchain local setting. As far as I understand the go directive, it's suppose to be set to the minimum version it still works with, not the version you want. Thanks in advance for your feedback.

@JorTurFer
Copy link
Member Author

umm... interesting point!
WDYT @zroubalik @wozniakjan ?

HeavyWombat added a commit to HeavyWombat/keda that referenced this pull request Nov 29, 2024
@HeavyWombat
Use toolchain to define desired Go version
69bbbd4 
Follow-up from: kedacore#6305 (comment)

Ref: https://go.dev/doc/modules/gomod-ref#go

Use toolchain to define the desired Go compiler version to be used.

Use `go` directive to show the minimum version it can still compile
with.

Signed-off-by: Matthias Diester <mddiester@gmail.com>
@HeavyWombat HeavyWombat mentioned this pull request Nov 29, 2024
Merged
2 tasks
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@JorTurFer @mpechner-akasa
Bump deps (kedacore#6305)
b4cee85 
Signed-off-by: michael pechner <mike.pechner@akasa.com>
@wozniakjan
Copy link
Member

I realize I'm a bit late to the party, just wanted to say I like the suggestion.

Does this mean the toolchain will be set to the go version KEDA CI is using to build the images and go version will be the latest version of go that a particular KEDA will successfully compile?

HeavyWombat added a commit to HeavyWombat/keda that referenced this pull request Dec 2, 2024
@HeavyWombat
Use toolchain to define desired Go version
8bf524d 
Follow-up from: kedacore#6305 (comment)

Ref: https://go.dev/doc/modules/gomod-ref#go

Use toolchain to define the desired Go compiler version to be used.

Use `go` directive to show the minimum version it can still compile
with.

Signed-off-by: Matthias Diester <mddiester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @HeavyWombat @wozniakjan @zroubalik