Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump k8s deps to 0.31.2 #185

Merged
merged 3 commits into from
Nov 5, 2024
Merged

chore: Bump k8s deps to 0.31.2 #185

merged 3 commits into from
Nov 5, 2024

Conversation

JorTurFer
Copy link
Contributor

We are preparing the new KEDA release and we want to bump k8s deps. This PR bumps k8s deps to 0.31. Could you merge this PR and ship a release?

@JorTurFer
chore: Bump k8s deps to 0.31.2
a05aaf6 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @JorTurFer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2024
@JorTurFer JorTurFer mentioned this pull request Nov 2, 2024
Merged
1 task
dgrisonnet
dgrisonnet approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2024
@dgrisonnet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 4, 2024
@JorTurFer
Fix deprecated code
a1e8cfc 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Contributor Author

/retest

@JorTurFer
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@JorTurFer: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-custom-metrics-apiserver-build-test-adapter
  • /test pull-custom-metrics-apiserver-test
  • /test pull-custom-metrics-apiserver-verify

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JorTurFer
update selfgenerated code
e783d89 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@JorTurFer: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-custom-metrics-apiserver-build-test-adapter
  • /test pull-custom-metrics-apiserver-test
  • /test pull-custom-metrics-apiserver-verify

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JorTurFer
Copy link
Contributor Author

I've fixed the PR issues 😄

dgrisonnet
dgrisonnet approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, JorTurFer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 84dc8cf into kubernetes-sigs:master Nov 5, 2024
5 checks passed
@JorTurFer JorTurFer deleted the bump-k8s-deps branch November 5, 2024 19:52
This was referenced Nov 5, 2024
Closed
Closed
@RainbowMango
Copy link
Member

@dgrisonnet any plan to tag a new release for this?

@RainbowMango
Copy link
Member

For guys who are waiting for the new release, you can use the pseudo version(v1.30.1-0.20241105195130-84dc8cfe2555) temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@olivierlemasle olivierlemasle Awaiting requested review from olivierlemasle

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @k8s-ci-robot @dgrisonnet @RainbowMango