[kedro-datasets] Bump version of tables in test_requirements.txt
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
changed the title
tables step from GA to test_requirements.txt (kedro-datasets)tables in test_requirements.txt
merelcht
reviewed
Apr 19, 2023
kedro-datasets/test_requirements.txt
Outdated
Comment on lines
56
to
57
| tables~=3.7.0; platform_system == "Windows" | ||
| tables~=3.7; platform_system != "Windows" |
There was a problem hiding this comment.
Can't these two lines just be merged to tables~=3.7 now?
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
SajidAlamQB
approved these changes
Apr 20, 2023
merelcht
approved these changes
Apr 25, 2023
BrianCechmanek
pushed a commit
to BrianCechmanek/kedro-plugins
that referenced
this pull request
Apr 25, 2023
…edro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com>
BrianCechmanek
pushed a commit
to BrianCechmanek/kedro-plugins
that referenced
this pull request
Apr 25, 2023
…edro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com>
noklam
added a commit
that referenced
this pull request
Apr 28, 2023
* refactor TensorFlowModelDataset to Set matching consistency of all other kedro-datasets, DataSet should be camelcase. will be reverted in 0.19.0 Signed-off-by: BrianCechmanek <brian@hazy.com> * Introdcuing .gitpod.yml to kedro-plugins (#185) Currently opening gitpod will installed a Python 3.11 which breaks everything because we don't support it set. This PR introduce a simple .gitpod.yml to get it started. Signed-off-by: BrianCechmanek <brian@hazy.com> * sync APIDataSet from kedro's `develop` (#184) * Update APIDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync ParquetDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync Test Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Linting Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Revert Unnecessary ParquetDataSet Changes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync release notes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * [kedro-datasets] Bump version of `tables` in `test_requirements.txt` (#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * refactor tensorflowModelDataset casing in datasets setup.py Signed-off-by: BrianCechmanek <brian@hazy.com> * add tensorflowmodeldataset bugfix to release.md Signed-off-by: BrianCechmanek <brian@hazy.com> * Update all the doc reference with TensorFlowModelDataSet Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: BrianCechmanek <brian@hazy.com> Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Co-authored-by: Nok Lam Chan <mediumnok@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Nok <nok.lam.chan@quantumblack.com>
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
May 3, 2023
…edro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
May 3, 2023
) * refactor TensorFlowModelDataset to Set matching consistency of all other kedro-datasets, DataSet should be camelcase. will be reverted in 0.19.0 Signed-off-by: BrianCechmanek <brian@hazy.com> * Introdcuing .gitpod.yml to kedro-plugins (kedro-org#185) Currently opening gitpod will installed a Python 3.11 which breaks everything because we don't support it set. This PR introduce a simple .gitpod.yml to get it started. Signed-off-by: BrianCechmanek <brian@hazy.com> * sync APIDataSet from kedro's `develop` (kedro-org#184) * Update APIDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync ParquetDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync Test Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Linting Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Revert Unnecessary ParquetDataSet Changes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync release notes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * [kedro-datasets] Bump version of `tables` in `test_requirements.txt` (kedro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * refactor tensorflowModelDataset casing in datasets setup.py Signed-off-by: BrianCechmanek <brian@hazy.com> * add tensorflowmodeldataset bugfix to release.md Signed-off-by: BrianCechmanek <brian@hazy.com> * Update all the doc reference with TensorFlowModelDataSet Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: BrianCechmanek <brian@hazy.com> Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Co-authored-by: Nok Lam Chan <mediumnok@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping the version of
pytablesfrom 3.6 to 3.7 allows it to be installed on windows system for higher versions (>3.9) of Python and we can remove the extra conditional step of installingtablesseparately forwindowsin the GitHub Actionsunit-testjob forkedro-datasets.Checklist
RELEASE.mdfile