fix(datasets): Refactor TensorFlowModelDataset to DataSet #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noklam
approved these changes
Apr 24, 2023
BrianCechmanek
force-pushed
the
fix/dataset-naming-tensorflowmodeldataset
branch
from
0018cc4 to
f5cbccd
Compare
matching consistency of all other kedro-datasets, DataSet should be camelcase. will be reverted in 0.19.0 Signed-off-by: BrianCechmanek <brian@hazy.com>
Currently opening gitpod will installed a Python 3.11 which breaks everything because we don't support it set. This PR introduce a simple .gitpod.yml to get it started. Signed-off-by: BrianCechmanek <brian@hazy.com>
* Update APIDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync ParquetDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync Test Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Linting Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Revert Unnecessary ParquetDataSet Changes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync release notes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: BrianCechmanek <brian@hazy.com>
…edro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com>
BrianCechmanek
force-pushed
the
fix/dataset-naming-tensorflowmodeldataset
branch
from
f5cbccd to
41aee34
Compare
Signed-off-by: BrianCechmanek <brian@hazy.com>
Signed-off-by: BrianCechmanek <brian@hazy.com>
|
Thanks both! @noklam, not sure if you meant for me specifically to add a comment to the Note: I couldn't get any of the commands in the makefile working, specifically to build and/or test this PR locally. I'll try and look into this next. |
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
noklam
changed the title
noklam
changed the title
noklam
changed the title
|
@BrianCechmanek Yes, that's great. I have made a few more changes in the doc and I am merging it now! Thanks |
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
May 3, 2023
) * refactor TensorFlowModelDataset to Set matching consistency of all other kedro-datasets, DataSet should be camelcase. will be reverted in 0.19.0 Signed-off-by: BrianCechmanek <brian@hazy.com> * Introdcuing .gitpod.yml to kedro-plugins (kedro-org#185) Currently opening gitpod will installed a Python 3.11 which breaks everything because we don't support it set. This PR introduce a simple .gitpod.yml to get it started. Signed-off-by: BrianCechmanek <brian@hazy.com> * sync APIDataSet from kedro's `develop` (kedro-org#184) * Update APIDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync ParquetDataSet Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync Test Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Linting Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Revert Unnecessary ParquetDataSet Changes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> * Sync release notes Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * [kedro-datasets] Bump version of `tables` in `test_requirements.txt` (kedro-org#182) * bump tables version and remove step in workflow Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert version for linux Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * change version to 3.7 Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * remove extra line Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: BrianCechmanek <brian@hazy.com> * refactor tensorflowModelDataset casing in datasets setup.py Signed-off-by: BrianCechmanek <brian@hazy.com> * add tensorflowmodeldataset bugfix to release.md Signed-off-by: BrianCechmanek <brian@hazy.com> * Update all the doc reference with TensorFlowModelDataSet Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: BrianCechmanek <brian@hazy.com> Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Co-authored-by: Nok Lam Chan <mediumnok@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Co-authored-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching consistency of all other kedro-datasets, DataSet should be camelcase.
It will be reverted in 0.19.0 per #2129.
Description
See previous discussion #2494.
All other supported DataSets have are camelcased (upper S).
Development notes
This refactors all instances of
TensorFlowModelDatasettoTensorFlowModelDataSet.There are also some instances of
TensorflowModelDataset, looking into if those should be changed as well (tbd)I couldn't run the test suite to verify - I will investigate that later.
Checklist
RELEASE.mdfile