-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move test requirements to optional dependencies in pyproject.toml #263
Conversation
449ce92
to
89be6b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thanks a lot @sbrugman!
The biggest change is going from our big dynamic setup.py
in kedro-datasets
to having all optional dependencies using self-referential requirements. I am personally a fan of this approach, but I am deferring to the engineering team to do the final approval.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super neat! ⭐ Thank you so much @sbrugman ! I left one question, but other than that I'm happy to get this merged.
I don't think it fully closes kedro-org/kedro#1498 yet because we'll need to remove any dataset related dependencies from the core repo for the 0.19.0
release, but it's definitely reduced the task.
d6fe82f
to
9633a1b
Compare
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
9633a1b
to
5dce6db
Compare
Rebased the changes on top of the @merelcht Could we merge this and then take on purging related dependencies from the core repo for the 0.19.0 release separately? (Fully moving to |
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
5dce6db
to
6d545ca
Compare
Yes absolutely. We are not working on any |
…oml (kedro-org#263) * Chore: Move test requirements to optional dependencies in pyproject.toml Signed-off-by: Simon Brugman <sfbbrugman@gmail.com> * Chore: Refactor setup.py for static dependencies Signed-off-by: Simon Brugman <sfbbrugman@gmail.com> * Chore: Replace setup.py with pyproject.toml Signed-off-by: Simon Brugman <sfbbrugman@gmail.com> * chore: remove `requirements-fixer` from pre-commit Signed-off-by: Simon Brugman <sfbbrugman@gmail.com> --------- Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Description
Fixes open todos:
kedro-datasets
(using recursive optional dependencies)Development notes
Closes kedro-org/kedro#1498 and closes #169
Checklist
RELEASE.md
file