Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if improvements are needed for test_requirements.txt setup #1498

Closed
3 tasks done
Tracked by #1457 ...
merelcht opened this issue May 4, 2022 · 5 comments · Fixed by kedro-org/kedro-plugins#263
Closed
3 tasks done
Tracked by #1457 ...
Assignees

Comments

@merelcht
Copy link
Member

merelcht commented May 4, 2022

Check if any of the below is still needed now we've implemented the pyproject.toml setup + datasets are removed:

  • Try and figure out a nicer way of installing all the dependencies listed in the setup.py file rather than needing to maintain a separate test_requirements.txt file there -> test_requirements.txt doesn't exist anymore. Instead of this do:
    • Remove setup.py.
  • Clean up kedro's test requirements to remove requirements for datasets that aren't needed any more
@sbrugman
Copy link
Contributor

test could be another extras_require. The tests_require now used in setup.py seem not to be part of the pyproject.toml metadata ([ref]), so this move would be a step in that direction (#1724).

@deepyaman
Copy link
Member

test could be another extras_require. The tests_require now used in setup.py seem not to be part of the pyproject.toml metadata ([ref]), so this move would be a step in that direction (#1724).

+1 on this approach; some packaging frameworks (like flit) have this special test extra (which I guess lends credibility to the approach?), and I've also used it on some other projects personally.

@astrojuanlu
Copy link
Member

Note that in #2475 tests_requires was removed, there's only test_requirements.txt. #2152 was partially addressed, so at least now even if there's a setup.py for some dynamic stuff, most of the metadata is in pyproject.toml. We could definitely add another optional-dependencies group (former "extras").

@astrojuanlu
Copy link
Member

Reopening, still some work to be done

@astrojuanlu astrojuanlu reopened this Jul 20, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Kedro Framework Jul 20, 2023
@merelcht merelcht moved this from In Progress to To Do in Kedro Framework Sep 18, 2023
@merelcht merelcht changed the title Improve test_requirements.txt setup Check if improvements are needed for test_requirements.txt setup Sep 18, 2023
@merelcht merelcht assigned merelcht and unassigned noklam Oct 2, 2023
@merelcht merelcht moved this from To Do to In Progress in Kedro Framework Oct 9, 2023
This was referenced Oct 9, 2023
@merelcht merelcht moved this from In Progress to In Review in Kedro Framework Oct 9, 2023
@merelcht
Copy link
Member Author

Completed in #3144 and #3143

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants